From 05fa36df725f592b9f84946bff5aa0f698e7a8bd Mon Sep 17 00:00:00 2001 From: Oliver Date: Sun, 23 Feb 2025 09:31:02 +1100 Subject: [PATCH] TODO Cleanup (#9152) --- src/frontend/src/forms/StockForms.tsx | 3 --- src/frontend/src/pages/Index/Settings/SystemSettings.tsx | 6 +++--- src/frontend/src/tables/part/PartTable.tsx | 2 -- src/frontend/src/tables/plugin/PluginListTable.tsx | 2 -- 4 files changed, 3 insertions(+), 10 deletions(-) diff --git a/src/frontend/src/forms/StockForms.tsx b/src/frontend/src/forms/StockForms.tsx index a2bc692674..5e65bc82ac 100644 --- a/src/frontend/src/forms/StockForms.tsx +++ b/src/frontend/src/forms/StockForms.tsx @@ -206,9 +206,6 @@ export function useStockFields({ delete_on_deplete: {} }; - // TODO: Handle custom field management based on provided options - // TODO: refer to stock.py in original codebase - // Remove the expiry date field if it is not enabled if (!globalSettings.isSet('STOCK_ENABLE_EXPIRY')) { delete fields.expiry_date; diff --git a/src/frontend/src/pages/Index/Settings/SystemSettings.tsx b/src/frontend/src/pages/Index/Settings/SystemSettings.tsx index ef854f63e3..71b012cb33 100644 --- a/src/frontend/src/pages/Index/Settings/SystemSettings.tsx +++ b/src/frontend/src/pages/Index/Settings/SystemSettings.tsx @@ -184,19 +184,19 @@ export default function SystemSettings() { 'PART_NAME_FORMAT', 'PART_SHOW_RELATED', 'PART_CREATE_INITIAL', - 'PART_CREATE_SUPPLIER', // TODO: Break here + 'PART_CREATE_SUPPLIER', 'PART_TEMPLATE', 'PART_ASSEMBLY', 'PART_COMPONENT', 'PART_TRACKABLE', 'PART_PURCHASEABLE', 'PART_SALABLE', - 'PART_VIRTUAL', // TODO: Break here + 'PART_VIRTUAL', 'PART_COPY_BOM', 'PART_COPY_PARAMETERS', 'PART_COPY_TESTS', 'PART_CATEGORY_PARAMETERS', - 'PART_CATEGORY_DEFAULT_ICON' // TODO: Move to part category settings page + 'PART_CATEGORY_DEFAULT_ICON' ]} /> ) diff --git a/src/frontend/src/tables/part/PartTable.tsx b/src/frontend/src/tables/part/PartTable.tsx index 5d90183639..3d037475b4 100644 --- a/src/frontend/src/tables/part/PartTable.tsx +++ b/src/frontend/src/tables/part/PartTable.tsx @@ -129,8 +129,6 @@ function partTableColumns(): TableColumn[] { ); } - // TODO: Add extra information on stock "demand" - if (stock <= 0) { color = 'red'; text = t`No stock`; diff --git a/src/frontend/src/tables/plugin/PluginListTable.tsx b/src/frontend/src/tables/plugin/PluginListTable.tsx index 2d3af946fb..75ff9a0428 100644 --- a/src/frontend/src/tables/plugin/PluginListTable.tsx +++ b/src/frontend/src/tables/plugin/PluginListTable.tsx @@ -119,8 +119,6 @@ export default function PluginListTable() { render: (record: any) => { return record?.meta.version; } - - // TODO: Display date information if available }, { accessor: 'meta.author',