From 0657b71fe8fdeca1992a4f950d310219e1844d2b Mon Sep 17 00:00:00 2001
From: Matthias <matthias.mair@oewf.org>
Date: Thu, 14 Oct 2021 22:19:52 +0200
Subject: [PATCH] clearer name and PEP foxes

---
 InvenTree/common/models.py | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/InvenTree/common/models.py b/InvenTree/common/models.py
index 0a5e87e3fa..3302d06eb1 100644
--- a/InvenTree/common/models.py
+++ b/InvenTree/common/models.py
@@ -475,9 +475,12 @@ class BaseInvenTreeSetting(models.Model):
 
         return value
 
-def group_options():
+
+def settings_group_options():
+    """build up group tuple for settings based on gour choices"""
     return [('', _('No group')), *[(str(a.id), str(a)) for a in Group.objects.all()]]
 
+
 class InvenTreeSetting(BaseInvenTreeSetting):
     """
     An InvenTreeSetting object is a key:value pair used for storing
@@ -848,7 +851,7 @@ class InvenTreeSetting(BaseInvenTreeSetting):
             'name': _('Group on signup'),
             'description': _('Group new user are asigned on registration'),
             'default': '',
-            'choices': group_options
+            'choices': settings_group_options
         },
     }