2
0
mirror of https://github.com/inventree/InvenTree.git synced 2025-05-01 04:56:45 +00:00

PEP style fixes

This commit is contained in:
Oliver 2018-04-23 21:18:35 +10:00
parent 86a9b36c99
commit 08ed128bea
18 changed files with 47 additions and 98 deletions

View File

@ -18,9 +18,6 @@ from django.conf.urls.static import static
from django.views.generic.base import RedirectView from django.views.generic.base import RedirectView
# from project.urls import prj_urls, prj_part_urls, prj_cat_urls, prj_run_urls
# from track.urls import unique_urls, part_track_urls
from users.urls import user_urls from users.urls import user_urls
admin.site.site_header = "InvenTree Admin" admin.site.site_header = "InvenTree Admin"
@ -29,36 +26,6 @@ apipatterns = [
url(r'^part/', include(part_api_urls)), url(r'^part/', include(part_api_urls)),
url(r'^company/', include(company_api_urls)), url(r'^company/', include(company_api_urls)),
# Stock URLs
#url(r'^stock/', include(stock_api_urls)),
#url(r'^stock-location/', include(stock_api_loc_urls)),
# Part URLs
#url(r'^part/', include(part_api_urls)),
#url(r'^part-category/', include(part_cat_api_urls)),
# url(r'^part-param/', include(part_param_urls)),
# url(r'^part-param-template/', include(part_param_template_urls)),
# Part BOM URLs
#url(r'^bom/', include(bom_api_urls)),
# Supplier URLs
# url(r'^supplier/', include(supplier_api_urls)),
# url(r'^supplier-part/', include(supplier_api_part_urls)),
# url(r'^price-break/', include(price_break_urls)),
# url(r'^manufacturer/', include(manu_urls)),
# Tracking URLs
# url(r'^track/', include(part_track_urls)),
# url(r'^unique-part/', include(unique_urls)),
# Project URLs
# url(r'^project/', include(prj_urls)),
# url(r'^project-category/', include(prj_cat_urls)),
# url(r'^project-part/', include(prj_part_urls)),
# url(r'^project-run/', include(prj_run_urls)),
# User URLs # User URLs
url(r'^user/', include(user_urls)), url(r'^user/', include(user_urls)),
] ]

View File

@ -6,8 +6,6 @@ from django.utils.translation import ugettext as _
from django.db import models from django.db import models
from django.core.validators import MinValueValidator from django.core.validators import MinValueValidator
#from part.models import Part
class Build(models.Model): class Build(models.Model):
""" A Build object organises the creation of new parts from the component parts """ A Build object organises the creation of new parts from the component parts

View File

@ -1,5 +1,4 @@
from django.conf.urls import url, include from django.conf.urls import url, include
from django.views.generic.base import RedirectView
from . import views from . import views

View File

@ -2,10 +2,9 @@
from __future__ import unicode_literals from __future__ import unicode_literals
from django.shortcuts import get_object_or_404 from django.shortcuts import get_object_or_404
from django.http import HttpResponseRedirect
from django.views.generic import DetailView, ListView from django.views.generic import DetailView, ListView
from django.views.generic.edit import UpdateView, DeleteView, CreateView from django.views.generic.edit import UpdateView, CreateView
from part.models import Part from part.models import Part
from .models import Build from .models import Build

View File

@ -2,15 +2,10 @@ from django.contrib import admin
from import_export.admin import ImportExportModelAdmin from import_export.admin import ImportExportModelAdmin
from .models import Company from .models import Company
#from .models import SupplierOrder
class CompanyAdmin(ImportExportModelAdmin): class CompanyAdmin(ImportExportModelAdmin):
list_display = ('name', 'website', 'contact') list_display = ('name', 'website', 'contact')
#class SupplierOrderAdmin(admin.ModelAdmin):
# list_display = ('internal_ref', 'supplier', 'issued_date', 'delivery_date', 'status')
admin.site.register(Company, CompanyAdmin) admin.site.register(Company, CompanyAdmin)
#admin.site.register(SupplierOrder, SupplierOrderAdmin)

View File

@ -1,7 +1,7 @@
# -*- coding: utf-8 -*- # -*- coding: utf-8 -*-
from __future__ import unicode_literals from __future__ import unicode_literals
from django_filters.rest_framework import FilterSet, DjangoFilterBackend from django_filters.rest_framework import DjangoFilterBackend
from rest_framework import filters from rest_framework import filters
from rest_framework import generics, permissions from rest_framework import generics, permissions

View File

@ -28,6 +28,7 @@ class EditSupplierOrderForm(forms.ModelForm):
] ]
""" """
class EditCompanyForm(forms.ModelForm): class EditCompanyForm(forms.ModelForm):
def __init__(self, *args, **kwargs): def __init__(self, *args, **kwargs):

View File

@ -0,0 +1,25 @@
# -*- coding: utf-8 -*-
# Generated by Django 1.11.12 on 2018-04-23 11:17
from __future__ import unicode_literals
from django.db import migrations, models
class Migration(migrations.Migration):
dependencies = [
('company', '0002_auto_20180422_1201'),
]
operations = [
migrations.AlterField(
model_name='company',
name='is_supplier',
field=models.BooleanField(default=True),
),
migrations.AlterField(
model_name='company',
name='name',
field=models.CharField(help_text='Company name', max_length=100, unique=True),
),
]

View File

@ -3,10 +3,7 @@ from __future__ import unicode_literals
import os import os
from django.utils.translation import ugettext as _
from django.db import models from django.db import models
from django.core.validators import MinValueValidator
def rename_company_image(instance, filename): def rename_company_image(instance, filename):
@ -22,7 +19,7 @@ def rename_company_image(instance, filename):
if ext: if ext:
fn += '.' + ext fn += '.' + ext
return os.path.join(base,fn) return os.path.join(base, fn)
class Company(models.Model): class Company(models.Model):
@ -51,7 +48,7 @@ class Company(models.Model):
is_customer = models.BooleanField(default=False) is_customer = models.BooleanField(default=False)
is_supplier = models.BooleanField(default=False) is_supplier = models.BooleanField(default=True)
def __str__(self): def __str__(self):
return self.name return self.name
@ -66,4 +63,3 @@ class Company(models.Model):
@property @property
def has_parts(self): def has_parts(self):
return self.part_count > 0 return self.part_count > 0

View File

@ -1,9 +1,8 @@
from rest_framework import serializers from rest_framework import serializers
from part.models import Part
from .models import Company from .models import Company
class CompanySerializer(serializers.HyperlinkedModelSerializer): class CompanySerializer(serializers.HyperlinkedModelSerializer):
class Meta: class Meta:

View File

@ -1,40 +1,15 @@
from django.shortcuts import get_object_or_404 # -*- coding: utf-8 -*-
from __future__ import unicode_literals
from django.http import HttpResponseRedirect from django.http import HttpResponseRedirect
from django.views.generic import DetailView, ListView from django.views.generic import DetailView, ListView
from django.views.generic.edit import UpdateView, DeleteView, CreateView from django.views.generic.edit import UpdateView, DeleteView, CreateView
from part.models import Part
from .models import Company from .models import Company
#from .models import SupplierOrder
from .forms import EditCompanyForm from .forms import EditCompanyForm
#from .forms import EditSupplierOrderForm
"""
class SupplierOrderDetail(DetailView):
context_object_name = 'order'
model = SupplierOrder
template_name = 'company/order_detail.html'
queryset = SupplierOrder.objects.all()
class SupplierOrderCreate(CreateView):
model = SupplierOrder
form_class = EditSupplierOrderForm
context_object_name = 'supplier'
template_name = 'company/order_create.html'
def get_initial(self):
initials = super(SupplierOrderCreate, self).get_initial().copy()
s_id = self.request.GET.get('supplier', None)
if s_id:
initials['supplier'] = get_object_or_404(Supplier, pk=s_id)
return initials
"""
class CompanyIndex(ListView): class CompanyIndex(ListView):
model = Company model = Company
@ -54,7 +29,6 @@ class CompanyIndex(ListView):
return queryset return queryset
class CompanyDetail(DetailView): class CompanyDetail(DetailView):
context_obect_name = 'company' context_obect_name = 'company'
template_name = 'company/detail.html' template_name = 'company/detail.html'
@ -86,5 +60,3 @@ class CompanyDelete(DeleteView):
return super(CompanyDelete, self).post(request, *args, **kwargs) return super(CompanyDelete, self).post(request, *args, **kwargs)
else: else:
return HttpResponseRedirect(self.get_object().get_absolute_url()) return HttpResponseRedirect(self.get_object().get_absolute_url())

View File

@ -4,7 +4,6 @@ from import_export.admin import ImportExportModelAdmin
from .models import PartCategory, Part from .models import PartCategory, Part
from .models import SupplierPart from .models import SupplierPart
from .models import BomItem from .models import BomItem
from .models import PartAttachment
class PartAdmin(ImportExportModelAdmin): class PartAdmin(ImportExportModelAdmin):
@ -21,9 +20,6 @@ class BomItemAdmin(ImportExportModelAdmin):
list_display = ('part', 'sub_part', 'quantity') list_display = ('part', 'sub_part', 'quantity')
#class PartAttachmentAdmin(admin.ModelAdmin):
# list_display = ('part', 'attachment')
class SupplierPartAdmin(ImportExportModelAdmin): class SupplierPartAdmin(ImportExportModelAdmin):
list_display = ('part', 'supplier', 'SKU') list_display = ('part', 'supplier', 'SKU')

View File

@ -1,7 +1,7 @@
# -*- coding: utf-8 -*- # -*- coding: utf-8 -*-
from __future__ import unicode_literals from __future__ import unicode_literals
from django_filters.rest_framework import FilterSet, DjangoFilterBackend from django_filters.rest_framework import DjangoFilterBackend
from rest_framework import filters from rest_framework import filters
from rest_framework import generics, permissions from rest_framework import generics, permissions
@ -27,7 +27,7 @@ class PartList(generics.ListCreateAPIView):
] ]
filter_fields = [ filter_fields = [
'category',
] ]
ordering_fields = [ ordering_fields = [
@ -36,6 +36,12 @@ class PartList(generics.ListCreateAPIView):
ordering = 'name' ordering = 'name'
search_fields = [
'name',
'description',
]
part_api_urls = [ part_api_urls = [
url(r'^.*$', PartList.as_view(), name='api-part-list'), url(r'^.*$', PartList.as_view(), name='api-part-list'),

View File

@ -13,6 +13,7 @@ from django.dispatch import receiver
from InvenTree.models import InvenTreeTree from InvenTree.models import InvenTreeTree
from company.models import Company from company.models import Company
class PartCategory(InvenTreeTree): class PartCategory(InvenTreeTree):
""" PartCategory provides hierarchical organization of Part objects. """ PartCategory provides hierarchical organization of Part objects.
""" """

View File

@ -1,5 +1,4 @@
from django.conf.urls import url, include from django.conf.urls import url, include
from django.views.generic.base import RedirectView
from . import views from . import views

View File

@ -52,6 +52,6 @@ class EditStockItemForm(forms.ModelForm):
'batch', 'batch',
'quantity', 'quantity',
'status', 'status',
#'customer', # 'customer',
'URL', 'URL',
] ]

View File

@ -11,11 +11,7 @@ from django.dispatch import receiver
from datetime import datetime from datetime import datetime
#from company.models import Company
#from part.models import Part
#from part.models import SupplierPart
from InvenTree.models import InvenTreeTree from InvenTree.models import InvenTreeTree
#from build.models import Build
class StockLocation(InvenTreeTree): class StockLocation(InvenTreeTree):

View File

@ -8,7 +8,7 @@ clean:
rm -f .coverage rm -f .coverage
style: style:
flake8 flake8 InvenTree
test: test:
python InvenTree/manage.py check python InvenTree/manage.py check