From 0d305e10f6dadd33cc2afb8be3ea6d97989b7838 Mon Sep 17 00:00:00 2001 From: "github-actions[bot]" <41898282+github-actions[bot]@users.noreply.github.com> Date: Fri, 31 Oct 2025 09:08:04 +1100 Subject: [PATCH] Fix selection list items not displaying values (#10722) (#10723) Fixes #10701 The issue was that the table row key was using 'props.item.pk', but the API returns 'id' instead. This caused React to not properly render the rows with their values. Changed the key to use 'props.item.id' with a fallback to 'props.idx' for new rows that don't have an ID yet. (cherry picked from commit 8d1f7f39b4c01d1b72fc33caa5a4bbb23b715a6d) Signed-off-by: Akhil Singh Co-authored-by: Akhil Singh <35478226+akhilsingh-git@users.noreply.github.com> --- src/frontend/src/forms/selectionListFields.tsx | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/frontend/src/forms/selectionListFields.tsx b/src/frontend/src/forms/selectionListFields.tsx index d26af88a00..c3b864d572 100644 --- a/src/frontend/src/forms/selectionListFields.tsx +++ b/src/frontend/src/forms/selectionListFields.tsx @@ -1,11 +1,9 @@ +import type { ApiFormFieldSet, ApiFormFieldType } from '@lib/types/Forms'; import { t } from '@lingui/core/macro'; import { Table } from '@mantine/core'; import { useMemo } from 'react'; - import RemoveRowButton from '../components/buttons/RemoveRowButton'; import { StandaloneField } from '../components/forms/StandaloneField'; - -import type { ApiFormFieldSet, ApiFormFieldType } from '@lib/types/Forms'; import type { TableFieldRowProps } from '../components/forms/fields/TableField'; function BuildAllocateLineRow({ @@ -62,7 +60,7 @@ function BuildAllocateLineRow({ }, [props]); return ( - +