inventree/InvenTree
2
0
Fork 0
mirror of https://github.com/inventree/InvenTree.git synced 2025-10-31 05:05:42 +00:00
Code Activity

refactor method name

Browse Source
This commit is contained in:
Matthias
2021-12-04 00:58:13 +01:00
parent 33b7d9b845
commit 0f3a78c7be
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
InvenTree/common/notifications.py
View File

@@ -17,7 +17,7 @@ logger = logging.getLogger('inventree')
# region notification classes
# region base classes
class NotificationMethod:
method_name = ''
METHOD_NAME = ''
def __init__(self, obj, entry_name, receivers) -> None:
# Check if a sending fnc is defined
@@ -55,7 +55,7 @@ class BulkNotificationMethod(NotificationMethod):
# region implementations
class EmailNotification(BulkNotificationMethod):
method_name = 'mail'
METHOD_NAME = 'mail'
def get_recipients(self):
return EmailAddress.objects.filter(
@@ -124,7 +124,7 @@ def trigger_notifaction(obj, entry_name=None, obj_ref='pk', receivers=None, rece
print(delivery_methods)
for method in [a for a in delivery_methods if a not in [SingleNotificationMethod, BulkNotificationMethod]]:
logger.info(f"Triggering method '{method.method_name}'")
logger.info(f"Triggering method '{method.METHOD_NAME}'")
try:
deliver_notification(method, obj, entry_name, receivers, notification_context)
except NotImplementedError as error:
@@ -146,7 +146,7 @@ def deliver_notification(cls: NotificationMethod, obj, entry_name: str, receiver
if method.recipients and method.recipients.count() > 0:
# Log start
logger.info(f"Notify users via '{method.method_name}' for notification '{entry_name}' for '{str(obj)}'")
logger.info(f"Notify users via '{method.METHOD_NAME}' for notification '{entry_name}' for '{str(obj)}'")
# Run setup for delivery method
method.setup()
@@ -173,6 +173,6 @@ def deliver_notification(cls: NotificationMethod, obj, entry_name: str, receiver
method.cleanup()
# Log results
logger.info(f"Notified {success_count} users via '{method.method_name}' for notification '{entry_name}' for '{str(obj)}' successfully")
logger.info(f"Notified {success_count} users via '{method.METHOD_NAME}' for notification '{entry_name}' for '{str(obj)}' successfully")
if not success:
logger.info("There were some problems")