From 1cefdfc2e4a831370a1859b80fdcd0bd72d21c57 Mon Sep 17 00:00:00 2001 From: Oliver Walters Date: Wed, 4 May 2022 17:31:44 +1000 Subject: [PATCH] PEP style fixes --- InvenTree/InvenTree/metadata.py | 2 +- InvenTree/build/models.py | 2 +- InvenTree/build/views.py | 4 +--- InvenTree/order/api.py | 1 - InvenTree/order/serializers.py | 3 +-- InvenTree/order/views.py | 5 ++--- InvenTree/stock/api.py | 1 + InvenTree/stock/forms.py | 10 +--------- InvenTree/stock/views.py | 1 + 9 files changed, 9 insertions(+), 20 deletions(-) diff --git a/InvenTree/InvenTree/metadata.py b/InvenTree/InvenTree/metadata.py index 8a8be64a37..c3ae8f6127 100644 --- a/InvenTree/InvenTree/metadata.py +++ b/InvenTree/InvenTree/metadata.py @@ -42,7 +42,7 @@ class InvenTreeMetadata(SimpleMetadata): """ Custom context information to pass through to the OPTIONS endpoint, if the "context=True" is supplied to the OPTIONS requst - + Serializer class can supply context data by defining a get_context_data() method (no arguments) """ diff --git a/InvenTree/build/models.py b/InvenTree/build/models.py index 464ef33f8d..a1517d73dd 100644 --- a/InvenTree/build/models.py +++ b/InvenTree/build/models.py @@ -486,7 +486,7 @@ class Build(MPTTModel, ReferenceIndexingMixin): for output in self.complete_outputs: quantity += output.quantity - + return quantity @property diff --git a/InvenTree/build/views.py b/InvenTree/build/views.py index ff12d2f211..80d648f53a 100644 --- a/InvenTree/build/views.py +++ b/InvenTree/build/views.py @@ -9,11 +9,9 @@ from django.utils.translation import gettext_lazy as _ from django.views.generic import DetailView, ListView from .models import Build -from . import forms -from InvenTree.views import AjaxUpdateView, AjaxDeleteView +from InvenTree.views import AjaxDeleteView from InvenTree.views import InvenTreeRoleMixin -from InvenTree.helpers import str2bool from InvenTree.status_codes import BuildStatus diff --git a/InvenTree/order/api.py b/InvenTree/order/api.py index c54476a733..2dab7684de 100644 --- a/InvenTree/order/api.py +++ b/InvenTree/order/api.py @@ -337,7 +337,6 @@ class PurchaseOrderIssue(PurchaseOrderContextMixin, generics.CreateAPIView): serializer_class = serializers.PurchaseOrderIssueSerializer - class PurchaseOrderReceive(PurchaseOrderContextMixin, generics.CreateAPIView): """ API endpoint to receive stock items against a purchase order. diff --git a/InvenTree/order/serializers.py b/InvenTree/order/serializers.py index 6f6654db1f..c0ab91a41f 100644 --- a/InvenTree/order/serializers.py +++ b/InvenTree/order/serializers.py @@ -204,7 +204,7 @@ class PurchaseOrderCancelSerializer(serializers.Serializer): if not order.can_cancel(): raise ValidationError(_("Order cannot be cancelled")) - + order.cancel_order() @@ -238,7 +238,6 @@ class PurchaseOrderIssueSerializer(serializers.Serializer): class Meta: fields = [] - def save(self): diff --git a/InvenTree/order/views.py b/InvenTree/order/views.py index 73c22aca22..81a96ba37e 100644 --- a/InvenTree/order/views.py +++ b/InvenTree/order/views.py @@ -30,9 +30,8 @@ from common.files import FileManager from . import forms as order_forms from part.views import PartPricing -from InvenTree.views import AjaxView, AjaxUpdateView -from InvenTree.helpers import DownloadFile, str2bool -from InvenTree.views import InvenTreeRoleMixin +from InvenTree.helpers import DownloadFile +from InvenTree.views import InvenTreeRoleMixin, AjaxView logger = logging.getLogger("inventree") diff --git a/InvenTree/stock/api.py b/InvenTree/stock/api.py index 78b56a43df..a42b6a2869 100644 --- a/InvenTree/stock/api.py +++ b/InvenTree/stock/api.py @@ -107,6 +107,7 @@ class StockItemContextMixin: return context + class StockItemSerialize(StockItemContextMixin, generics.CreateAPIView): """ API endpoint for serializing a stock item diff --git a/InvenTree/stock/forms.py b/InvenTree/stock/forms.py index 8e0017b3fd..7d419ab478 100644 --- a/InvenTree/stock/forms.py +++ b/InvenTree/stock/forms.py @@ -5,17 +5,9 @@ Django Forms for interacting with Stock app # -*- coding: utf-8 -*- from __future__ import unicode_literals -from django import forms -from django.forms.utils import ErrorDict -from django.utils.translation import gettext_lazy as _ - -from mptt.fields import TreeNodeChoiceField - from InvenTree.forms import HelperForm -from InvenTree.fields import RoundingDecimalFormField -from InvenTree.fields import DatePickerFormField -from .models import StockLocation, StockItem, StockItemTracking +from .models import StockItem, StockItemTracking class ReturnStockItemForm(HelperForm): diff --git a/InvenTree/stock/views.py b/InvenTree/stock/views.py index 69f0426bba..01d2b67c73 100644 --- a/InvenTree/stock/views.py +++ b/InvenTree/stock/views.py @@ -5,6 +5,7 @@ Django views for interacting with Stock app # -*- coding: utf-8 -*- from __future__ import unicode_literals +from datetime import datetime from django.views.generic import DetailView, ListView from django.urls import reverse