inventree/InvenTree
2
0
Fork 0
mirror of https://github.com/inventree/InvenTree.git synced 2025-12-16 17:28:11 +00:00
Code Activity

Fix typos

Browse Source
This commit is contained in:
Oliver Walters
2025-11-24 12:22:32 +00:00
parent b1fa9ab889
commit 2432762451
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/backend/InvenTree/InvenTree/serializers.py
View File

@@ -69,7 +69,7 @@ def enable_filter(
Returns: Returns:
The decorated serializer field, marked as filterable. The decorated serializer field, marked as filterable.
""" """
# Ensure this function can be actually filteres # Ensure this function can be actually filtered
if not issubclass(func.__class__, FilterableSerializerField): if not issubclass(func.__class__, FilterableSerializerField):
raise TypeError( raise TypeError(
'INVE-I2: `enable_filter` can only be applied to serializer fields / serializers that contain the `FilterableSerializerField` mixin!' 'INVE-I2: `enable_filter` can only be applied to serializer fields / serializers that contain the `FilterableSerializerField` mixin!'
@@ -132,11 +132,11 @@ class FilterableSerializerMixin:
query_params = dict(getattr(context.get('request', {}), 'query_params', {})) query_params = dict(getattr(context.get('request', {}), 'query_params', {}))
# Remove filter args from kwargs to avoid issues with super().__init__ # Remove filter args from kwargs to avoid issues with super().__init__
poped_kwargs = {} # store popped kwargs as a arg might be reused for multiple fields popped_kwargs = {} # store popped kwargs as a arg might be reused for multiple fields
tgs_vals: dict[str, bool] = {} tgs_vals: dict[str, bool] = {}
for k, v in self.filter_targets.items(): for k, v in self.filter_targets.items():
pop_ref = v['filter_name'] or k pop_ref = v['filter_name'] or k
val = kwargs.pop(pop_ref, poped_kwargs.get(pop_ref)) val = kwargs.pop(pop_ref, popped_kwargs.get(pop_ref))
# Optionally also look in query parameters # Optionally also look in query parameters
if val is None and self.filter_on_query and v.get('filter_by_query', True): if val is None and self.filter_on_query and v.get('filter_by_query', True):
@@ -145,13 +145,13 @@ class FilterableSerializerMixin:
val = val[0] val = val[0]
if val: # Save popped value for reuse if val: # Save popped value for reuse
poped_kwargs[pop_ref] = val popped_kwargs[pop_ref] = val
tgs_vals[k] = ( tgs_vals[k] = (
str2bool(val) if isinstance(val, (str, int, float)) else val str2bool(val) if isinstance(val, (str, int, float)) else val
) # Support for various filtering style for backwards compatibility ) # Support for various filtering style for backwards compatibility
self.filter_target_values = tgs_vals self.filter_target_values = tgs_vals
# Ensure this mixin is not proadly applied as it is expensive on scale (total CI time increased by 21% when running all coverage tests) # Ensure this mixin is not broadly applied as it is expensive on scale (total CI time increased by 21% when running all coverage tests)
if len(self.filter_targets) == 0 and not self.no_filters: if len(self.filter_targets) == 0 and not self.no_filters:
raise Exception( raise Exception(
'INVE-I2: No filter targets found in fields, remove `PathScopedMixin`' 'INVE-I2: No filter targets found in fields, remove `PathScopedMixin`'