inventree/InvenTree
2
0
Fork 0
mirror of https://github.com/inventree/InvenTree.git synced 2025-12-14 08:19:54 +00:00
Code Activity

Refactor previous code for looking up "previous" and "next" serial numbers

Browse Source 
- Old way was extremely inefficient, especially when large spaces existed between serial numbers
- New method reduces O(n) to O(1)
This commit is contained in:
Oliver
2022-03-07 13:47:38 +11:00
parent d9f73ae05b
commit 2f3f57148a
2 changed files with 56 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files

41
InvenTree/stock/views.py
View File

@@ -101,43 +101,16 @@ class StockItemDetail(InvenTreeRoleMixin, DetailView):
model = StockItem
def get_context_data(self, **kwargs):
""" add previous and next item """
"""
Add information on the "next" and "previous" StockItem objects,
based on the serial numbers.
"""
data = super().get_context_data(**kwargs)
if self.object.serialized:
serial_elem = {}
try:
current = int(self.object.serial)
for item in self.object.part.stock_items.all():
if item.serialized:
try:
sn = int(item.serial)
serial_elem[sn] = item
except ValueError:
# We only support integer serial number progression
pass
serials = serial_elem.keys()
# previous
for nbr in range(current - 1, min(serials), -1):
if nbr in serials:
data['previous'] = serial_elem.get(nbr, None)
break
# next
for nbr in range(current + 1, max(serials) + 1):
if nbr in serials:
data['next'] = serial_elem.get(nbr, None)
break
except ValueError:
# We only support integer serial number progression
pass
data['previous'] = self.object.get_next_serial_number(reverse=True)
data['next'] = self.object.get_next_serial_number()
data['ownership_enabled'] = common.models.InvenTreeSetting.get_setting('STOCK_OWNERSHIP_CONTROL')
data['item_owner'] = self.object.get_item_owner()