From 30243002a4f5b2a3277f247ca5581b776a0b99f9 Mon Sep 17 00:00:00 2001 From: Oliver Date: Sun, 31 May 2026 10:09:29 +1000 Subject: [PATCH] [UI] Can build (#12043) * Fix for BuildDetail * Update playwright tests * update playwright Ref: https://github.com/microsoft/playwright/issues/40998 * Fix hooks --- src/frontend/src/pages/build/BuildDetail.tsx | 10 +++------- src/frontend/tests/pages/pui_build.spec.ts | 4 ++++ 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/frontend/src/pages/build/BuildDetail.tsx b/src/frontend/src/pages/build/BuildDetail.tsx index 0c762ff920..7460634ccb 100644 --- a/src/frontend/src/pages/build/BuildDetail.tsx +++ b/src/frontend/src/pages/build/BuildDetail.tsx @@ -331,7 +331,7 @@ export default function BuildDetail() { name: 'can_build', unit: build.part_detail?.units, label: t`Can Build`, - hidden: partRequirementsQuery.isFetching + hidden: partRequirements?.can_build === undefined }, { type: 'progressbar', @@ -454,12 +454,7 @@ export default function BuildDetail() { ); - }, [ - build, - instanceQuery, - partRequirements, - partRequirementsQuery.isFetching - ]); + }, [build, instanceQuery, partRequirements, partRequirementsQuery]); const buildPanels: PanelType[] = useMemo(() => { return [ @@ -597,6 +592,7 @@ export default function BuildDetail() { build, id, user, + partRequirements, buildStatus, globalSettings, showChildBuilds, diff --git a/src/frontend/tests/pages/pui_build.spec.ts b/src/frontend/tests/pages/pui_build.spec.ts index 362f9b34e2..b54fadc6d7 100644 --- a/src/frontend/tests/pages/pui_build.spec.ts +++ b/src/frontend/tests/pages/pui_build.spec.ts @@ -45,8 +45,12 @@ test('Build Order - Basic Tests', async ({ browser }) => { // Load a particular build order await page.getByRole('cell', { name: 'BO0017' }).click(); + await loadTab(page, 'Build Details'); + // This build order should be "on hold" await page.getByText('On Hold').first().waitFor(); + await page.getByText('Can Build').first().waitFor(); + await page.getByText('Completed Outputs').first().waitFor(); // Edit the build order (via keyboard shortcut) await page.keyboard.press('Control+E');