From 31e25eb50b7d22139c4d310170dd8ada9fab5d72 Mon Sep 17 00:00:00 2001
From: Matthias Mair <code@mjmair.com>
Date: Thu, 9 Jan 2025 00:10:17 +0100
Subject: [PATCH] re-enable registration tests

---
 src/backend/InvenTree/InvenTree/test_auth.py | 43 +++++++-------------
 1 file changed, 15 insertions(+), 28 deletions(-)

diff --git a/src/backend/InvenTree/InvenTree/test_auth.py b/src/backend/InvenTree/InvenTree/test_auth.py
index 091121be84..82cfbda809 100644
--- a/src/backend/InvenTree/InvenTree/test_auth.py
+++ b/src/backend/InvenTree/InvenTree/test_auth.py
@@ -1,7 +1,5 @@
 """Test the sso and auth module functionality."""
 
-import unittest
-
 from django.conf import settings
 from django.contrib.auth.models import Group, User
 from django.core.exceptions import ValidationError
@@ -143,6 +141,9 @@ class EmailSettingsContext:
 class TestAuth(InvenTreeAPITestCase):
     """Test authentication functionality."""
 
+    reg_url = '/api/auth/v1/auth/signup'
+    test_email = 'tester@example.com'
+
     def test_buildin_token(self):
         """Test the built-in token authentication."""
         self.logout()
@@ -165,41 +166,29 @@ class TestAuth(InvenTreeAPITestCase):
     def email_args(self, user=None, email=None):
         """Generate registration arguments."""
         return {
-            'username': user or 'user1',
-            'email': email or 'test@example.com',
-            'password1': '#asdf1234',
-            'password2': '#asdf1234',
+            'username': user or 'user2',
+            'email': email or self.test_email,
+            'password': '#asdf1234',
         }
 
-    @unittest.skip
     def test_registration(self):
         """Test the registration process."""
         self.logout()
 
         # Duplicate username
         resp = self.post(
-            '/api/auth/registration/',
-            self.email_args(user='testuser'),
-            expected_code=400,
-        )
-        self.assertIn(
-            'A user with that username already exists.', resp.data['username']
+            self.reg_url, self.email_args(user='testuser'), expected_code=400
         )
+        self.assertIn('A user with that username already exists.', str(resp.json()))
 
         # Registration is disabled
-        resp = self.post(
-            '/api/auth/registration/', self.email_args(), expected_code=400
-        )
-        self.assertIn('Registration is disabled.', resp.data['non_field_errors'])
+        self.post(self.reg_url, self.email_args(), expected_code=403)
 
         # Enable registration - now it should work
         with EmailSettingsContext():
-            resp = self.post(
-                '/api/auth/registration/', self.email_args(), expected_code=201
-            )
-            self.assertIn('key', resp.data)
+            resp = self.post(self.reg_url, self.email_args(), expected_code=200)
+            self.assertEqual(resp.json()['data']['user']['email'], self.test_email)
 
-    @unittest.skip
     def test_registration_email(self):
         """Test that LOGIN_SIGNUP_MAIL_RESTRICTION works."""
         self.logout()
@@ -220,15 +209,13 @@ class TestAuth(InvenTreeAPITestCase):
 
         # Wrong email format
         resp = self.post(
-            '/api/auth/registration/',
+            self.reg_url,
             self.email_args(email='admin@invenhost.com'),
             expected_code=400,
         )
-        self.assertIn('The provided email domain is not approved.', resp.data['email'])
+        self.assertIn('The provided email domain is not approved.', str(resp.json()))
 
         # Right format should work
         with EmailSettingsContext():
-            resp = self.post(
-                '/api/auth/registration/', self.email_args(), expected_code=201
-            )
-            self.assertIn('key', resp.data)
+            resp = self.post(self.reg_url, self.email_args(), expected_code=200)
+            self.assertEqual(resp.json()['data']['user']['email'], self.test_email)