inventree/InvenTree
2
0
Fork 0
mirror of https://github.com/inventree/InvenTree.git synced 2025-04-28 11:36:44 +00:00
Code

Exception handling for BulkDeleteMixin (#8205)

Browse Source 
* Exception handling for BulkDeleteMixin

* Fix unit test
This commit is contained in:
Oliver 2024-09-29 15:37:18 +10:00 committed by GitHub
parent 390fec3ab1
commit 33499d61bd
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 18 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
src/backend/InvenTree/InvenTree/api.py
View File

@ -379,11 +379,26 @@ class BulkDeleteMixin:
# Filter by provided item ID values # Filter by provided item ID values
if items: if items:
queryset = queryset.filter(id__in=items) try:
queryset = queryset.filter(id__in=items)
except Exception:
raise ValidationError({
'non_field_errors': _('Invalid items list provided')
})
# Filter by provided filters # Filter by provided filters
if filters: if filters:
queryset = queryset.filter(**filters) try:
queryset = queryset.filter(**filters)
except Exception:
raise ValidationError({
'non_field_errors': _('Invalid filters provided')
})
if queryset.count() == 0:
raise ValidationError({
'non_field_errors': _('No items found to delete')
})
# Run a final validation step (should raise an error if the deletion should not proceed) # Run a final validation step (should raise an error if the deletion should not proceed)
self.validate_delete(queryset, request) self.validate_delete(queryset, request)

2
src/backend/InvenTree/stock/test_api.py
View File

@ -1874,7 +1874,7 @@ class StockTestResultTest(StockAPITestCase):
# Now, let's delete all the newly created items with a single API request # Now, let's delete all the newly created items with a single API request
# However, we will provide incorrect filters # However, we will provide incorrect filters
response = self.delete( response = self.delete(
url, {'items': tests, 'filters': {'stock_item': 10}}, expected_code=204 url, {'items': tests, 'filters': {'stock_item': 10}}, expected_code=400
) )
self.assertEqual(StockItemTestResult.objects.count(), n + 50) self.assertEqual(StockItemTestResult.objects.count(), n + 50)