From 4593b0f4127813cddbbcf1498fd4868fe5f3af95 Mon Sep 17 00:00:00 2001 From: Oliver Walters Date: Sat, 2 Apr 2022 11:12:54 +1100 Subject: [PATCH] Unit test fixes --- InvenTree/part/test_api.py | 2 +- InvenTree/part/test_bom_item.py | 2 +- InvenTree/stock/test_api.py | 25 +++++++++++++------------ 3 files changed, 15 insertions(+), 14 deletions(-) diff --git a/InvenTree/part/test_api.py b/InvenTree/part/test_api.py index 133ebee0e1..56a32c2cb5 100644 --- a/InvenTree/part/test_api.py +++ b/InvenTree/part/test_api.py @@ -250,7 +250,7 @@ class PartAPITest(InvenTreeAPITestCase): data = {'cascade': True} response = self.client.get(url, data, format='json') self.assertEqual(response.status_code, status.HTTP_200_OK) - self.assertEqual(len(response.data), 13) + self.assertEqual(len(response.data), Part.objects.count()) def test_get_parts_by_cat(self): url = reverse('api-part-list') diff --git a/InvenTree/part/test_bom_item.py b/InvenTree/part/test_bom_item.py index 7466277118..88548f3cf7 100644 --- a/InvenTree/part/test_bom_item.py +++ b/InvenTree/part/test_bom_item.py @@ -46,7 +46,7 @@ class BomItemTest(TestCase): # TODO: Tests for multi-level BOMs def test_used_in(self): - self.assertEqual(self.bob.used_in_count, 0) + self.assertEqual(self.bob.used_in_count, 1) self.assertEqual(self.orphan.used_in_count, 1) def test_self_reference(self): diff --git a/InvenTree/stock/test_api.py b/InvenTree/stock/test_api.py index 81973aed31..e078c74189 100644 --- a/InvenTree/stock/test_api.py +++ b/InvenTree/stock/test_api.py @@ -104,7 +104,7 @@ class StockItemListTest(StockAPITestCase): response = self.get_stock() - self.assertEqual(len(response), 20) + self.assertEqual(len(response), 29) def test_filter_by_part(self): """ @@ -113,7 +113,7 @@ class StockItemListTest(StockAPITestCase): response = self.get_stock(part=25) - self.assertEqual(len(response), 8) + self.assertEqual(len(response), 17) response = self.get_stock(part=10004) @@ -136,10 +136,10 @@ class StockItemListTest(StockAPITestCase): self.assertEqual(len(response), 1) response = self.get_stock(location=1, cascade=0) - self.assertEqual(len(response), 0) + self.assertEqual(len(response), 7) response = self.get_stock(location=1, cascade=1) - self.assertEqual(len(response), 2) + self.assertEqual(len(response), 9) response = self.get_stock(location=7) self.assertEqual(len(response), 16) @@ -153,7 +153,7 @@ class StockItemListTest(StockAPITestCase): self.assertEqual(len(response), 1) response = self.get_stock(depleted=0) - self.assertEqual(len(response), 19) + self.assertEqual(len(response), 28) def test_filter_by_in_stock(self): """ @@ -161,7 +161,7 @@ class StockItemListTest(StockAPITestCase): """ response = self.get_stock(in_stock=1) - self.assertEqual(len(response), 17) + self.assertEqual(len(response), 26) response = self.get_stock(in_stock=0) self.assertEqual(len(response), 3) @@ -172,7 +172,7 @@ class StockItemListTest(StockAPITestCase): """ codes = { - StockStatus.OK: 18, + StockStatus.OK: 27, StockStatus.DESTROYED: 1, StockStatus.LOST: 1, StockStatus.DAMAGED: 0, @@ -205,7 +205,7 @@ class StockItemListTest(StockAPITestCase): self.assertIsNotNone(item['serial']) response = self.get_stock(serialized=0) - self.assertEqual(len(response), 8) + self.assertEqual(len(response), 17) for item in response: self.assertIsNone(item['serial']) @@ -217,7 +217,7 @@ class StockItemListTest(StockAPITestCase): # First, we can assume that the 'stock expiry' feature is disabled response = self.get_stock(expired=1) - self.assertEqual(len(response), 20) + self.assertEqual(len(response), 29) self.user.is_staff = True self.user.save() @@ -232,7 +232,7 @@ class StockItemListTest(StockAPITestCase): self.assertTrue(item['expired']) response = self.get_stock(expired=0) - self.assertEqual(len(response), 19) + self.assertEqual(len(response), 28) for item in response: self.assertFalse(item['expired']) @@ -290,7 +290,8 @@ class StockItemListTest(StockAPITestCase): dataset = self.export_data({}) - self.assertEqual(len(dataset), 20) + # Check that *all* stock item objects have been exported + self.assertEqual(len(dataset), StockItem.objects.count()) # Expected headers headers = [ @@ -308,7 +309,7 @@ class StockItemListTest(StockAPITestCase): # Now, add a filter to the results dataset = self.export_data({'location': 1}) - self.assertEqual(len(dataset), 2) + self.assertEqual(len(dataset), 9) dataset = self.export_data({'part': 25})