From 4921cd47f9f8caa7fab488200dbe6476a70868e1 Mon Sep 17 00:00:00 2001
From: Matthias <matmair@live.de>
Date: Fri, 25 Jun 2021 07:40:01 +0200
Subject: [PATCH] refactor for better readabilty

---
 InvenTree/part/templates/part/prices.html | 30 +++++++++++++----------
 InvenTree/templates/js/part.js            |  8 ++++++
 2 files changed, 25 insertions(+), 13 deletions(-)

diff --git a/InvenTree/part/templates/part/prices.html b/InvenTree/part/templates/part/prices.html
index 1b8b3959cf..cf719711dc 100644
--- a/InvenTree/part/templates/part/prices.html
+++ b/InvenTree/part/templates/part/prices.html
@@ -340,7 +340,7 @@
                         borderWidth: 1
                     }]
                 }
-            var StockPriceChart = loadStockPricingChart(document.getElementById('StockPriceChart'), pricedata)
+            var StockPriceChart = loadStockPricingChart($('#StockPriceChart'), pricedata)
             var bom_colors =  randomColor({hue: 'green', count: {{ bom_parts|length }} })
             var bomdata = {
                 labels: [{% for line in bom_parts %}'{{ line.name }}',{% endfor %}],
@@ -369,12 +369,14 @@
     {% if show_internal_price and roles.sales_order.view %}
         initPriceBreakSet(
             $('#internal-price-break-table'),
-            {{part.id}},
-            'internal price break',
-            'internal-price',
-            "{% url 'api-part-internal-price-list' %}",
-            $('#new-internal-price-break'),
-            '{% url 'internal-price-break-create' %}'
+            {
+                part_id: {{part.id}},
+                pb_human_name: 'internal price break',
+                pb_url_slug: 'internal-price',
+                pb_url: '{% url 'api-part-internal-price-list' %}',
+                pb_new_btn: $('#new-internal-price-break'),
+                pb_new_url: '{% url 'internal-price-break-create' %}',
+            },
         );
     {% endif %}
 
@@ -393,12 +395,14 @@
     {% if part.salable and roles.sales_order.view %}
         initPriceBreakSet(
             $('#price-break-table'),
-            {{part.id}},
-            'sale price break',
-            'sale-price',
-            "{% url 'api-part-sale-price-list' %}",
-            $('#new-price-break'),
-            '{% url 'sale-price-break-create' %}'
+            {
+                part_id: {{part.id}},
+                pb_human_name: 'sale price break',
+                pb_url_slug: 'sale-price',
+                pb_url: "{% url 'api-part-sale-price-list' %}",
+                pb_new_btn: $('#new-price-break'),
+                pb_new_url: '{% url 'sale-price-break-create' %}',
+            },
         );
     {% endif %}
 
diff --git a/InvenTree/templates/js/part.js b/InvenTree/templates/js/part.js
index 82fd416e15..37fd36486b 100644
--- a/InvenTree/templates/js/part.js
+++ b/InvenTree/templates/js/part.js
@@ -817,6 +817,14 @@ function loadPriceBreakTable(table, options) {
     });
 }
 
+function initPriceBreakSet(table, options) {
+
+    var part_id = options.part_id;
+    var pb_human_name = options.pb_human_name;
+    var pb_url_slug = options.pb_url_slug;
+    var pb_url = options.pb_url;
+    var pb_new_btn = options.pb_new_btn;
+    var pb_new_url = options.pb_new_url;
 
 function initPriceBreakSet(table, part_id, pb_human_name, pb_url_slug, pb_url, pb_new_btn, pb_new_url) {