inventree/InvenTree
2
0
Fork 0
mirror of https://github.com/inventree/InvenTree.git synced 2025-04-29 12:06:44 +00:00
Code

Error checking for attachment model type (#7506)

Browse Source
This commit is contained in:
Oliver 2024-06-25 11:48:00 +10:00 committed by GitHub
parent c6ad902ccc
commit 4989e86349
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/backend/InvenTree/common/models.py
View File

@ -3241,6 +3241,6 @@ class Attachment(InvenTree.models.MetadataMixin, InvenTree.models.InvenTreeModel
) )
if not issubclass(model_class, InvenTreeAttachmentMixin): if not issubclass(model_class, InvenTreeAttachmentMixin):
raise ValueError(_('Invalid model type specified for attachment')) raise ValidationError(_('Invalid model type specified for attachment'))
return model_class.check_attachment_permission(permission, user) return model_class.check_attachment_permission(permission, user)

5
src/backend/InvenTree/common/validators.py
View File

@ -29,11 +29,14 @@ def attachment_model_options():
def attachment_model_class_from_label(label: str): def attachment_model_class_from_label(label: str):
"""Return the model class for the given label.""" """Return the model class for the given label."""
if not label:
raise ValidationError(_('No attachment model type provided'))
for model in attachment_model_types(): for model in attachment_model_types():
if model.__name__.lower() == label.lower(): if model.__name__.lower() == label.lower():
return model return model
raise ValueError(f'Invalid attachment model label: {label}') raise ValidationError(_('Invalid attachment model type') + f": '{label}'")
def validate_attachment_model_type(value): def validate_attachment_model_type(value):