From 4f3e8cb0a022685866f519ba167a1640f335a3ce Mon Sep 17 00:00:00 2001 From: Matthias Mair Date: Mon, 2 Dec 2024 11:42:31 +0100 Subject: [PATCH] [PUI] infinite loop if classic frontend is disabled (#8614) Fixes #8575 --- src/backend/InvenTree/plugin/plugin.py | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/backend/InvenTree/plugin/plugin.py b/src/backend/InvenTree/plugin/plugin.py index 95c7cd6711..a5c11c0eba 100644 --- a/src/backend/InvenTree/plugin/plugin.py +++ b/src/backend/InvenTree/plugin/plugin.py @@ -375,15 +375,13 @@ class InvenTreePlugin(VersionMixin, MixinBase, MetaBase): return self.check_package_install_name() @property - def settings_url(self): + def settings_url(self) -> str: """URL to the settings panel for this plugin.""" if settings.ENABLE_CLASSIC_FRONTEND: return f'{reverse("settings")}#select-plugin-{self.slug}' - config = self.plugin_config() - if config: + if config := self.db: return InvenTree.helpers.pui_url(f'/settings/admin/plugin/{config.pk}/') - else: - return InvenTree.helpers.pui_url('/settings/admin/plugin/') + return InvenTree.helpers.pui_url('/settings/admin/plugin/') # region package info def _get_package_commit(self):