From 623a0844d3c01d5584863168ed06d93eee22dcc2 Mon Sep 17 00:00:00 2001 From: Oliver Walters Date: Tue, 7 Apr 2020 11:50:46 +1000 Subject: [PATCH] Coverage tests for new functions --- InvenTree/InvenTree/helpers.py | 2 +- InvenTree/InvenTree/tests.py | 18 ++++++++++++++++++ 2 files changed, 19 insertions(+), 1 deletion(-) diff --git a/InvenTree/InvenTree/helpers.py b/InvenTree/InvenTree/helpers.py index d46f35daf4..6b29adb4c4 100644 --- a/InvenTree/InvenTree/helpers.py +++ b/InvenTree/InvenTree/helpers.py @@ -101,7 +101,7 @@ def isNull(text): True if the text looks like a null value """ - return str(text).strip().lower() in ['top', 'null', 'none', 'empty', 'false', '-1'] + return str(text).strip().lower() in ['top', 'null', 'none', 'empty', 'false', '-1', ''] def decimal2string(d): diff --git a/InvenTree/InvenTree/tests.py b/InvenTree/InvenTree/tests.py index 2511cf4318..1fc660c7d8 100644 --- a/InvenTree/InvenTree/tests.py +++ b/InvenTree/InvenTree/tests.py @@ -72,6 +72,24 @@ class TestHelpers(TestCase): self.assertFalse(helpers.str2bool(s)) self.assertFalse(helpers.str2bool(s, test=False)) + def test_isnull(self): + + for s in ['null', 'none', '', '-1', 'false']: + self.assertTrue(helpers.isNull(s)) + + for s in ['yes', 'frog', 'llama', 'true']: + self.assertFalse(helpers.isNull(s)) + + def testStaticUrl(self): + + self.assertEqual(helpers.getStaticUrl('test.jpg'), '/static/test.jpg') + self.assertEqual(helpers.getBlankImage(), '/static/img/blank_image.png') + self.assertEqual(helpers.getBlankThumbnail(), '/static/img/blank_image.thumbnail.png') + + def testMediaUrl(self): + + self.assertEqual(helpers.getMediaUrl('xx/yy.png'), '/media/xx/yy.png') + class TestQuoteWrap(TestCase): """ Tests for string wrapping """