From 63f6776e83f5c13f1718f154ba58e81f3ad7c319 Mon Sep 17 00:00:00 2001 From: Matthias Date: Fri, 3 Dec 2021 09:00:32 +0100 Subject: [PATCH 1/3] set default ref --- .github/workflows/qc_checks.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/qc_checks.yaml b/.github/workflows/qc_checks.yaml index 86834348be..ebf375629a 100644 --- a/.github/workflows/qc_checks.yaml +++ b/.github/workflows/qc_checks.yaml @@ -35,7 +35,7 @@ jobs: uses: actions/checkout@v2 - name: Check version number run: | - python3 ci/check_version_number.py --branch ${{ github.base_ref }} + python3 ci/check_version_number.py --branch ${{ github.base_ref || github.ref }} pep_style: name: PEP style (python) From c1052b6c1dfe4d51f9cab419c293726b5426902b Mon Sep 17 00:00:00 2001 From: Matthias Date: Fri, 3 Dec 2021 20:14:48 +0100 Subject: [PATCH 2/3] only trigger version number if pullrequest --- .github/workflows/qc_checks.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/qc_checks.yaml b/.github/workflows/qc_checks.yaml index ebf375629a..0687bd5083 100644 --- a/.github/workflows/qc_checks.yaml +++ b/.github/workflows/qc_checks.yaml @@ -29,13 +29,14 @@ jobs: check_version: name: version number runs-on: ubuntu-latest + if: ${{ github.event_name == 'pull_request' }} steps: - name: Checkout Code uses: actions/checkout@v2 - name: Check version number run: | - python3 ci/check_version_number.py --branch ${{ github.base_ref || github.ref }} + python3 ci/check_version_number.py --branch ${{ github.base_ref }} pep_style: name: PEP style (python) From b871115484da4fa9d9ad07ec7440303576ea9f6e Mon Sep 17 00:00:00 2001 From: Matthias Date: Fri, 3 Dec 2021 20:24:01 +0100 Subject: [PATCH 3/3] always run style --- .github/workflows/qc_checks.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/qc_checks.yaml b/.github/workflows/qc_checks.yaml index 0687bd5083..a9bb80f4ab 100644 --- a/.github/workflows/qc_checks.yaml +++ b/.github/workflows/qc_checks.yaml @@ -42,6 +42,7 @@ jobs: name: PEP style (python) needs: check_version runs-on: ubuntu-latest + if: always() steps: - name: Checkout code