From 713aec1ae3046fe9063b48b7e1580e61a1f8d183 Mon Sep 17 00:00:00 2001
From: Stan Dekker <stan@mook-dekker.nl>
Date: Sat, 15 Apr 2023 00:34:01 +0200
Subject: [PATCH] Remove "required" attribute for order descriptions (#4595)

* Made the description field on the part model optional

* Made the title field on the build model optional

* Made the description field on the order model optional

* Added migration files
---
 .../migrations/0041_alter_build_title.py      | 18 ++++++++++++
 InvenTree/build/models.py                     |  4 +--
 .../migrations/0090_auto_20230412_1752.py     | 28 +++++++++++++++++++
 InvenTree/order/models.py                     |  2 +-
 .../migrations/0104_alter_part_description.py | 18 ++++++++++++
 InvenTree/part/models.py                      |  4 +--
 6 files changed, 69 insertions(+), 5 deletions(-)
 create mode 100644 InvenTree/build/migrations/0041_alter_build_title.py
 create mode 100644 InvenTree/order/migrations/0090_auto_20230412_1752.py
 create mode 100644 InvenTree/part/migrations/0104_alter_part_description.py

diff --git a/InvenTree/build/migrations/0041_alter_build_title.py b/InvenTree/build/migrations/0041_alter_build_title.py
new file mode 100644
index 0000000000..3962587526
--- /dev/null
+++ b/InvenTree/build/migrations/0041_alter_build_title.py
@@ -0,0 +1,18 @@
+# Generated by Django 3.2.18 on 2023-04-12 17:52
+
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('build', '0040_auto_20230404_1310'),
+    ]
+
+    operations = [
+        migrations.AlterField(
+            model_name='build',
+            name='title',
+            field=models.CharField(blank=True, help_text='Brief description of the build (optional)', max_length=100, verbose_name='Description'),
+        ),
+    ]
diff --git a/InvenTree/build/models.py b/InvenTree/build/models.py
index 7ac1c0f6e0..235897ef4b 100644
--- a/InvenTree/build/models.py
+++ b/InvenTree/build/models.py
@@ -164,9 +164,9 @@ class Build(MPTTModel, InvenTreeBarcodeMixin, MetadataMixin, ReferenceIndexingMi
 
     title = models.CharField(
         verbose_name=_('Description'),
-        blank=False,
+        blank=True,
         max_length=100,
-        help_text=_('Brief description of the build')
+        help_text=_('Brief description of the build (optional)')
     )
 
     parent = TreeForeignKey(
diff --git a/InvenTree/order/migrations/0090_auto_20230412_1752.py b/InvenTree/order/migrations/0090_auto_20230412_1752.py
new file mode 100644
index 0000000000..e337d6c949
--- /dev/null
+++ b/InvenTree/order/migrations/0090_auto_20230412_1752.py
@@ -0,0 +1,28 @@
+# Generated by Django 3.2.18 on 2023-04-12 17:52
+
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('order', '0089_auto_20230404_0030'),
+    ]
+
+    operations = [
+        migrations.AlterField(
+            model_name='purchaseorder',
+            name='description',
+            field=models.CharField(blank=True, help_text='Order description (optional)', max_length=250, verbose_name='Description'),
+        ),
+        migrations.AlterField(
+            model_name='returnorder',
+            name='description',
+            field=models.CharField(blank=True, help_text='Order description (optional)', max_length=250, verbose_name='Description'),
+        ),
+        migrations.AlterField(
+            model_name='salesorder',
+            name='description',
+            field=models.CharField(blank=True, help_text='Order description (optional)', max_length=250, verbose_name='Description'),
+        ),
+    ]
diff --git a/InvenTree/order/models.py b/InvenTree/order/models.py
index 617aa92678..51d3cae0b9 100644
--- a/InvenTree/order/models.py
+++ b/InvenTree/order/models.py
@@ -197,7 +197,7 @@ class Order(InvenTreeBarcodeMixin, MetadataMixin, ReferenceIndexingMixin):
 
         return self.__class__.objects.filter(pk=self.pk).filter(self.__class__.overdue_filter()).exists()
 
-    description = models.CharField(max_length=250, verbose_name=_('Description'), help_text=_('Order description'))
+    description = models.CharField(max_length=250, blank=True, verbose_name=_('Description'), help_text=_('Order description (optional)'))
 
     link = InvenTreeURLField(blank=True, verbose_name=_('Link'), help_text=_('Link to external page'))
 
diff --git a/InvenTree/part/migrations/0104_alter_part_description.py b/InvenTree/part/migrations/0104_alter_part_description.py
new file mode 100644
index 0000000000..750e21f46b
--- /dev/null
+++ b/InvenTree/part/migrations/0104_alter_part_description.py
@@ -0,0 +1,18 @@
+# Generated by Django 3.2.18 on 2023-04-12 17:52
+
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('part', '0103_auto_20230317_0816'),
+    ]
+
+    operations = [
+        migrations.AlterField(
+            model_name='part',
+            name='description',
+            field=models.CharField(blank=True, help_text='Part description (optional)', max_length=250, verbose_name='Description'),
+        ),
+    ]
diff --git a/InvenTree/part/models.py b/InvenTree/part/models.py
index a5955bb967..89bbc5df26 100644
--- a/InvenTree/part/models.py
+++ b/InvenTree/part/models.py
@@ -856,9 +856,9 @@ class Part(InvenTreeBarcodeMixin, MetadataMixin, MPTTModel):
     )
 
     description = models.CharField(
-        max_length=250, blank=False,
+        max_length=250, blank=True,
         verbose_name=_('Description'),
-        help_text=_('Part description')
+        help_text=_('Part description (optional)')
     )
 
     keywords = models.CharField(