inventree/InvenTree
2
0
Fork 0
mirror of https://github.com/inventree/InvenTree.git synced 2025-07-06 21:50:55 +00:00
Code Activity

Add flake8-logging linting (#5620)

Browse Source 
* added flake8-logging to make logging more robust

* fixed LOG005 warnings

* fixed LOG008 warnings

* fixed LOG011 warnings

* fixed more LOG011 errors

* added ignores for intentional logger.error calls

* fixed even more LOG011 errors
This commit is contained in:
Matthias Mair
2023-09-28 06:53:22 +02:00
committed by GitHub
parent 08e7190832
commit 71c416bafd
45 changed files with 177 additions and 176 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
InvenTree/users/apps.py
View File

@ -44,7 +44,7 @@ class UsersConfig(AppConfig):
# First, delete any rule_set objects which have become outdated!
for rule in RuleSet.objects.all():
if rule.name not in RuleSet.RULESET_NAMES: # pragma: no cover # can not change ORM without the app being loaded
logger.info(f"Deleting outdated ruleset: {rule.name}")
logger.info("Deleting outdated ruleset: %s", rule.name)
rule.delete()
# Update group permission assignments for all groups

10
InvenTree/users/models.py
View File

@ -286,7 +286,7 @@ class RuleSet(models.Model):
# Print message instead of throwing an error
name = getattr(user, 'name', user.pk)
logger.debug(f"User '{name}' failed permission check for {table}.{permission}")
logger.debug("User '%s' failed permission check for %s.%s", name, table, permission)
return False
@ -457,7 +457,7 @@ def update_group_roles(group, debug=False):
content_type = ContentType.objects.get(app_label=app, model=model)
permission = Permission.objects.get(content_type=content_type, codename=perm)
except ContentType.DoesNotExist: # pragma: no cover
logger.warning(f"Error: Could not find permission matching '{permission_string}'")
logger.warning("Error: Could not find permission matching '%s'", permission_string)
permission = None
return permission
@ -475,7 +475,7 @@ def update_group_roles(group, debug=False):
group.permissions.add(permission)
if debug: # pragma: no cover
logger.debug(f"Adding permission {perm} to group {group.name}")
logger.debug("Adding permission %s to group %s", perm, group.name)
# Remove any extra permissions from the group
for perm in permissions_to_delete:
@ -490,7 +490,7 @@ def update_group_roles(group, debug=False):
group.permissions.remove(permission)
if debug: # pragma: no cover
logger.debug(f"Removing permission {perm} from group {group.name}")
logger.debug("Removing permission %s from group %s", perm, group.name)
# Enable all action permissions for certain children models
# if parent model has 'change' permission
@ -512,7 +512,7 @@ def update_group_roles(group, debug=False):
permission = get_permission_object(child_perm)
if permission:
group.permissions.add(permission)
logger.debug(f"Adding permission {child_perm} to group {group.name}")
logger.debug("Adding permission %s to group %s", child_perm, group.name)
def clear_user_role_cache(user):