From 76407d71b88eda0f0e16a24bcc5ddc521ced99e1 Mon Sep 17 00:00:00 2001 From: Oliver Date: Sat, 2 May 2026 10:04:41 +1000 Subject: [PATCH] [UI] Fix ReturnOrder table (#11845) * [UI] Fix ReturnOrder table - Closes https://github.com/inventree/InvenTree/issues/11833 * Add playwright test --- .../tables/sales/ReturnOrderLineItemTable.tsx | 4 +++- .../tests/customization/customization.spec.ts | 13 ------------- src/frontend/tests/pages/pui_part.spec.ts | 2 +- src/frontend/tests/pages/pui_return.spec.ts | 19 +++++++++++++++++++ 4 files changed, 23 insertions(+), 15 deletions(-) create mode 100644 src/frontend/tests/pages/pui_return.spec.ts diff --git a/src/frontend/src/tables/sales/ReturnOrderLineItemTable.tsx b/src/frontend/src/tables/sales/ReturnOrderLineItemTable.tsx index 23cef54278..7211b12a77 100644 --- a/src/frontend/src/tables/sales/ReturnOrderLineItemTable.tsx +++ b/src/frontend/src/tables/sales/ReturnOrderLineItemTable.tsx @@ -194,7 +194,9 @@ export default function ReturnOrderLineItemTable({ tooltip={t`Receive selected items`} icon={} hidden={ - !editable || inProgress || !user.hasChangeRole(UserRoles.return_order) + !editable || + !inProgress || + !user.hasChangeRole(UserRoles.return_order) } onClick={() => { setSelectedItems( diff --git a/src/frontend/tests/customization/customization.spec.ts b/src/frontend/tests/customization/customization.spec.ts index a026868ea8..9b792131ba 100644 --- a/src/frontend/tests/customization/customization.spec.ts +++ b/src/frontend/tests/customization/customization.spec.ts @@ -1,7 +1,5 @@ import test, { expect } from '@playwright/test'; -import { noaccessuser } from '../defaults'; import { navigate } from '../helpers'; -import { doLogin } from '../login'; /** * Tests for user interface customization functionality. @@ -20,14 +18,3 @@ test('Customization - Splash', async ({ page }) => { page.locator('[style*="playwright_custom_splash.png"]') ).toBeVisible(); }); - -test('Customization - Logo', async ({ page }) => { - await doLogin(page, { - user: noaccessuser - }); - - await page.waitForLoadState('networkidle'); - - await page.waitForTimeout(2500); - return; -}); diff --git a/src/frontend/tests/pages/pui_part.spec.ts b/src/frontend/tests/pages/pui_part.spec.ts index b70a561d09..cbe1fc6184 100644 --- a/src/frontend/tests/pages/pui_part.spec.ts +++ b/src/frontend/tests/pages/pui_part.spec.ts @@ -829,7 +829,7 @@ test('Parts - Parameter Filtering', async ({ browser }) => { test('Parts - Test Results', async ({ browser }) => { const page = await doCachedLogin(browser, { url: '/part/74/test_results' }); - await page.waitForTimeout(2500); + await page.waitForTimeout(500); await page.getByText(/1 - \d+ \/ 1\d\d/).waitFor(); await page.getByText('Blue Paint Applied').waitFor(); diff --git a/src/frontend/tests/pages/pui_return.spec.ts b/src/frontend/tests/pages/pui_return.spec.ts new file mode 100644 index 0000000000..b3656a1c30 --- /dev/null +++ b/src/frontend/tests/pages/pui_return.spec.ts @@ -0,0 +1,19 @@ +import test from '@playwright/test'; +import { loadTab } from '../helpers'; +import { doCachedLogin } from '../login'; + +test('Return Orders - Receive Items', async ({ browser }) => { + const page = await doCachedLogin(browser, { + url: 'sales/index/returnorders' + }); + + await page.getByRole('cell', { name: 'RMA-0002' }).click(); + await loadTab(page, 'Parameters'); + await loadTab(page, 'Attachments'); + await loadTab(page, 'Line Items'); + + await page.getByRole('checkbox', { name: 'Select all records' }).click(); + await page.getByRole('button', { name: 'action-button-receive-' }).click(); + await page.getByRole('banner').getByText('Receive Items').waitFor(); + await page.getByRole('button', { name: 'Cancel' }).click(); +});