From 78243027b242a4cd7e80e6c26ed1e4beebe76efe Mon Sep 17 00:00:00 2001
From: Matthias Mair <code@mjmair.com>
Date: Mon, 15 Apr 2024 13:45:16 +0200
Subject: [PATCH] fix selects

---
 src/frontend/src/tables/Filter.tsx                     | 2 +-
 src/frontend/src/tables/FilterSelectDrawer.tsx         | 2 +-
 src/frontend/src/tables/bom/BomTable.tsx               | 6 ++++++
 src/frontend/src/tables/bom/UsedInTable.tsx            | 2 ++
 src/frontend/src/tables/build/BuildLineTable.tsx       | 1 +
 src/frontend/src/tables/build/BuildOrderTable.tsx      | 2 ++
 src/frontend/src/tables/machine/MachineListTable.tsx   | 3 +++
 src/frontend/src/tables/part/PartTestTemplateTable.tsx | 4 ++++
 src/frontend/src/tables/stock/StockLocationTable.tsx   | 2 ++
 9 files changed, 22 insertions(+), 2 deletions(-)

diff --git a/src/frontend/src/tables/Filter.tsx b/src/frontend/src/tables/Filter.tsx
index 4a61f30a12..cf6d7aabe9 100644
--- a/src/frontend/src/tables/Filter.tsx
+++ b/src/frontend/src/tables/Filter.tsx
@@ -20,7 +20,7 @@ export type TableFilterChoice = {
  */
 export type TableFilter = {
   name: string;
-  label?: string;
+  label: string;
   description?: string;
   type?: string;
   choices?: TableFilterChoice[];
diff --git a/src/frontend/src/tables/FilterSelectDrawer.tsx b/src/frontend/src/tables/FilterSelectDrawer.tsx
index c015769e08..a51c5a0b52 100644
--- a/src/frontend/src/tables/FilterSelectDrawer.tsx
+++ b/src/frontend/src/tables/FilterSelectDrawer.tsx
@@ -142,7 +142,7 @@ function FilterAddGroup({
       <Divider />
       <Select
         data={filterOptions}
-        itemComponent={FilterSelectItem}
+        component={FilterSelectItem}
         searchable={true}
         placeholder={t`Select filter`}
         label={t`Filter`}
diff --git a/src/frontend/src/tables/bom/BomTable.tsx b/src/frontend/src/tables/bom/BomTable.tsx
index 9da22cb0f6..6abf1425d5 100644
--- a/src/frontend/src/tables/bom/BomTable.tsx
+++ b/src/frontend/src/tables/bom/BomTable.tsx
@@ -241,26 +241,32 @@ export function BomTable({
       },
       {
         name: 'available_stock',
+        label: t`Available Stock`,
         description: t`Show items with available stock`
       },
       {
         name: 'on_order',
+        label: t`On Order`,
         description: t`Show items on order`
       },
       {
         name: 'validated',
+        label: t`Validated`,
         description: t`Show validated items`
       },
       {
         name: 'inherited',
+        label: t`Inherited`,
         description: t`Show inherited items`
       },
       {
         name: 'optional',
+        label: t`Optional`,
         description: t`Show optional items`
       },
       {
         name: 'consumable',
+        label: t`Consumable`,
         description: t`Show consumable items`
       },
       {
diff --git a/src/frontend/src/tables/bom/UsedInTable.tsx b/src/frontend/src/tables/bom/UsedInTable.tsx
index 6f62a7ef31..3bb1911ce4 100644
--- a/src/frontend/src/tables/bom/UsedInTable.tsx
+++ b/src/frontend/src/tables/bom/UsedInTable.tsx
@@ -51,10 +51,12 @@ export function UsedInTable({
     return [
       {
         name: 'inherited',
+        label: t`Inherited`,
         description: t`Show inherited items`
       },
       {
         name: 'optional',
+        label: t`Optional`,
         description: t`Show optional items`
       },
       {
diff --git a/src/frontend/src/tables/build/BuildLineTable.tsx b/src/frontend/src/tables/build/BuildLineTable.tsx
index 2a78cec0b6..8dcae7b608 100644
--- a/src/frontend/src/tables/build/BuildLineTable.tsx
+++ b/src/frontend/src/tables/build/BuildLineTable.tsx
@@ -31,6 +31,7 @@ export default function BuildLineTable({ params = {} }: { params?: any }) {
     return [
       {
         name: 'allocated',
+        label: t`Allocated`,
         description: t`Show allocated lines`
       },
       {
diff --git a/src/frontend/src/tables/build/BuildOrderTable.tsx b/src/frontend/src/tables/build/BuildOrderTable.tsx
index 66a15af959..90f6d68904 100644
--- a/src/frontend/src/tables/build/BuildOrderTable.tsx
+++ b/src/frontend/src/tables/build/BuildOrderTable.tsx
@@ -104,11 +104,13 @@ export function BuildOrderTable({
       },
       {
         name: 'status',
+        label: t`Status`,
         description: t`Filter by order status`,
         choiceFunction: StatusFilterOptions(ModelType.build)
       },
       {
         name: 'overdue',
+        label: t`Overdue`,
         type: 'boolean',
         description: t`Show overdue status`
       },
diff --git a/src/frontend/src/tables/machine/MachineListTable.tsx b/src/frontend/src/tables/machine/MachineListTable.tsx
index 2ca40c8c3c..cfb857297f 100644
--- a/src/frontend/src/tables/machine/MachineListTable.tsx
+++ b/src/frontend/src/tables/machine/MachineListTable.tsx
@@ -582,10 +582,12 @@ export function MachineListTable({
           tableFilters: [
             {
               name: 'active',
+              label: t`Active`,
               type: 'boolean'
             },
             {
               name: 'machine_type',
+              label: t`Machine Type`,
               type: 'choice',
               choiceFunction: () =>
                 machineTypes
@@ -594,6 +596,7 @@ export function MachineListTable({
             },
             {
               name: 'driver',
+              label: t`Driver`,
               type: 'choice',
               choiceFunction: () =>
                 machineDrivers
diff --git a/src/frontend/src/tables/part/PartTestTemplateTable.tsx b/src/frontend/src/tables/part/PartTestTemplateTable.tsx
index b1f4841651..f96fda50b0 100644
--- a/src/frontend/src/tables/part/PartTestTemplateTable.tsx
+++ b/src/frontend/src/tables/part/PartTestTemplateTable.tsx
@@ -76,18 +76,22 @@ export default function PartTestTemplateTable({ partId }: { partId: number }) {
     return [
       {
         name: 'required',
+        label: t`Required`,
         description: t`Show required tests`
       },
       {
         name: 'enabled',
+        label: t`Enabled`,
         description: t`Show enabled tests`
       },
       {
         name: 'requires_value',
+        label: t`Requires Value`,
         description: t`Show tests that require a value`
       },
       {
         name: 'requires_attachment',
+        label: t`Requires Attachment`,
         description: t`Show tests that require an attachment`
       },
       {
diff --git a/src/frontend/src/tables/stock/StockLocationTable.tsx b/src/frontend/src/tables/stock/StockLocationTable.tsx
index 72aa7d61e2..1b2ef2b328 100644
--- a/src/frontend/src/tables/stock/StockLocationTable.tsx
+++ b/src/frontend/src/tables/stock/StockLocationTable.tsx
@@ -39,10 +39,12 @@ export function StockLocationTable({ parentId }: { parentId?: any }) {
       },
       {
         name: 'structural',
+        label: t`structural`,
         description: t`Show structural locations`
       },
       {
         name: 'external',
+        label: t`external`,
         description: t`Show external locations`
       },
       {