From 88b90281f5128b23fe820046a1e505d3dcd24cd0 Mon Sep 17 00:00:00 2001
From: Oliver Walters <oliver.henry.walters@gmail.com>
Date: Wed, 28 Aug 2019 19:56:35 +1000
Subject: [PATCH 01/11] Do not enforce serialization when creating a stock item

---
 InvenTree/stock/forms.py |  3 +-
 InvenTree/stock/views.py | 76 +++++++++++++++++++++-------------------
 2 files changed, 42 insertions(+), 37 deletions(-)

diff --git a/InvenTree/stock/forms.py b/InvenTree/stock/forms.py
index 46a50521dd..ecc71f3423 100644
--- a/InvenTree/stock/forms.py
+++ b/InvenTree/stock/forms.py
@@ -7,6 +7,7 @@ from __future__ import unicode_literals
 
 from django import forms
 from django.forms.utils import ErrorDict
+from django.utils.translation import ugettext as _
 
 from InvenTree.forms import HelperForm
 from .models import StockLocation, StockItem, StockItemTracking
@@ -27,7 +28,7 @@ class EditStockLocationForm(HelperForm):
 class CreateStockItemForm(HelperForm):
     """ Form for creating a new StockItem """
 
-    serial_numbers = forms.CharField(label='Serial numbers', required=False, help_text='Enter unique serial numbers')
+    serial_numbers = forms.CharField(label='Serial numbers', required=False, help_text=_('Enter unique serial numbers (or leave blank)'))
 
     class Meta:
         model = StockItem
diff --git a/InvenTree/stock/views.py b/InvenTree/stock/views.py
index 3d36eb91b9..6bf98fd26d 100644
--- a/InvenTree/stock/views.py
+++ b/InvenTree/stock/views.py
@@ -593,47 +593,51 @@ class StockItemCreate(AjaxCreateView):
                 if part.trackable:
                     sn = request.POST.get('serial_numbers', '')
 
-                    try:
-                        serials = ExtractSerialNumbers(sn, quantity)
+                    sn = str(sn).strip()
 
-                        existing = []
+                    # If user has specified a range of serial numbers
+                    if len(sn) > 0:
+                        try:
+                            serials = ExtractSerialNumbers(sn, quantity)
 
-                        for serial in serials:
-                            if not StockItem.check_serial_number(part, serial):
-                                existing.append(serial)
+                            existing = []
 
-                        if len(existing) > 0:
-                            exists = ",".join([str(x) for x in existing])
-                            form.errors['serial_numbers'] = [_('The following serial numbers already exist: ({sn})'.format(sn=exists))]
+                            for serial in serials:
+                                if not StockItem.check_serial_number(part, serial):
+                                    existing.append(serial)
+
+                            if len(existing) > 0:
+                                exists = ",".join([str(x) for x in existing])
+                                form.errors['serial_numbers'] = [_('The following serial numbers already exist: ({sn})'.format(sn=exists))]
+                                valid = False
+
+                            # At this point we have a list of serial numbers which we know are valid,
+                            # and do not currently exist
+                            form.clean()
+
+                            data = form.cleaned_data
+
+                            for serial in serials:
+                                # Create a new stock item for each serial number
+                                item = StockItem(
+                                    part=part,
+                                    quantity=1,
+                                    serial=serial,
+                                    supplier_part=data.get('supplier_part'),
+                                    location=data.get('location'),
+                                    batch=data.get('batch'),
+                                    delete_on_deplete=False,
+                                    status=data.get('status'),
+                                    notes=data.get('notes'),
+                                    URL=data.get('URL'),
+                                )
+
+                                item.save()
+
+                        except ValidationError as e:
+                            form.errors['serial_numbers'] = e.messages
                             valid = False
 
-                        # At this point we have a list of serial numbers which we know are valid,
-                        # and do not currently exist
-                        form.clean()
-
-                        data = form.cleaned_data
-
-                        for serial in serials:
-                            # Create a new stock item for each serial number
-                            item = StockItem(
-                                part=part,
-                                quantity=1,
-                                serial=serial,
-                                supplier_part=data.get('supplier_part'),
-                                location=data.get('location'),
-                                batch=data.get('batch'),
-                                delete_on_deplete=False,
-                                status=data.get('status'),
-                                notes=data.get('notes'),
-                                URL=data.get('URL'),
-                            )
-
-                            item.save()
-
-                    except ValidationError as e:
-                        form.errors['serial_numbers'] = e.messages
-                        valid = False
-
                 else:
                     # For non-serialized items, simply save the form.
                     # We need to call _post_clean() here because it is prevented in the form implementation

From bc03ae53bd1b22084d6deb5e85e8680d39f47307 Mon Sep 17 00:00:00 2001
From: Oliver Walters <oliver.henry.walters@gmail.com>
Date: Wed, 28 Aug 2019 20:01:38 +1000
Subject: [PATCH 02/11] Changes for clean of StockItem

---
 InvenTree/stock/models.py | 7 +++++--
 InvenTree/stock/views.py  | 3 +++
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/InvenTree/stock/models.py b/InvenTree/stock/models.py
index b5a88d4e66..5c90db78b5 100644
--- a/InvenTree/stock/models.py
+++ b/InvenTree/stock/models.py
@@ -204,12 +204,15 @@ class StockItem(models.Model):
                         })
 
                     if self.quantity == 0:
+                        self.quantity = 1
+
+                    elif self.quantity > 1:
                         raise ValidationError({
                             'quantity': _('Quantity must be 1 for item with a serial number')
                         })
 
-                    if self.delete_on_deplete:
-                        raise ValidationError({'delete_on_deplete': _("Must be set to False for item with a serial number")})
+                    # Serial numbered items cannot be deleted on depletion
+                    self.delete_on_deplete = False
 
                 # A template part cannot be instantiated as a StockItem
                 if self.part.is_template:
diff --git a/InvenTree/stock/views.py b/InvenTree/stock/views.py
index 6bf98fd26d..4ad10d1ada 100644
--- a/InvenTree/stock/views.py
+++ b/InvenTree/stock/views.py
@@ -467,6 +467,9 @@ class StockItemCreate(AjaxCreateView):
     Parameters can be pre-filled by passing query items:
     - part: The part of which the new StockItem is an instance
     - location: The location of the new StockItem
+
+    If the parent part is a "tracked" part, provide an option to create uniquely serialized items
+    rather than a bulk quantity of stock items
     """
 
     model = StockItem

From 43967e302bfd530d91cea23624af33e938e101a4 Mon Sep 17 00:00:00 2001
From: Oliver Walters <oliver.henry.walters@gmail.com>
Date: Wed, 28 Aug 2019 21:12:16 +1000
Subject: [PATCH 03/11] Add ablity to serialize an existing quantity of stock

- Do not have to serialize all the stock
- Add tests
- Add function to copy entire stock transaction history
---
 InvenTree/part/fixtures/part.yaml |  1 +
 InvenTree/part/models.py          |  3 +-
 InvenTree/stock/models.py         | 94 ++++++++++++++++++++++++++++++-
 InvenTree/stock/tests.py          | 78 +++++++++++++++++++++++++
 4 files changed, 172 insertions(+), 4 deletions(-)

diff --git a/InvenTree/part/fixtures/part.yaml b/InvenTree/part/fixtures/part.yaml
index 3f7fbb9886..77b96a3471 100644
--- a/InvenTree/part/fixtures/part.yaml
+++ b/InvenTree/part/fixtures/part.yaml
@@ -43,6 +43,7 @@
     name: 'Widget'
     description: 'A watchamacallit'
     category: 7
+    trackable: true
 
 - model: part.part
   pk: 50
diff --git a/InvenTree/part/models.py b/InvenTree/part/models.py
index 382eccdf07..4a4c5fb606 100644
--- a/InvenTree/part/models.py
+++ b/InvenTree/part/models.py
@@ -843,7 +843,8 @@ class Part(models.Model):
         # Copy the BOM data
         if kwargs.get('bom', False):
             for item in other.bom_items.all():
-                # Point the item to THIS part
+                # Point the item to THIS part.
+                # Set the pk to None so a new entry is created.
                 item.part = self
                 item.pk = None
                 item.save()
diff --git a/InvenTree/stock/models.py b/InvenTree/stock/models.py
index 5c90db78b5..86b1c7b2b9 100644
--- a/InvenTree/stock/models.py
+++ b/InvenTree/stock/models.py
@@ -138,6 +138,12 @@ class StockItem(models.Model):
         if not part.trackable:
             return False
 
+        # Return False if an invalid serial number is supplied
+        try:
+            serial_number = int(serial_number)
+        except ValueError:
+            return False
+
         items = StockItem.objects.filter(serial=serial_number)
 
         # Is this part a variant? If so, check S/N across all sibling variants
@@ -367,12 +373,91 @@ class StockItem(models.Model):
         track.save()
 
     @transaction.atomic
-    def serializeStock(self, serials, user):
+    def serializeStock(self, quantity, serials, user, location=None):
         """ Split this stock item into unique serial numbers.
+
+        - Quantity can be less than or equal to the quantity of the stock item
+        - Number of serial numbers must match the quantity
+        - Provided serial numbers must not already be in use
+
+        Args:
+            quantity: Number of items to serialize (integer)
+            serials: List of serial numbers (list<int>)
+            user: User object associated with action
+            location: If specified, serialized items will be placed in the given location
         """
 
-        # TODO
-        pass
+        # Cannot serialize stock that is already serialized!
+        if self.serialized:
+            return
+
+        # Do not serialize non-trackable parts
+        if not self.part.trackable:
+            raise ValueError({"part": _("Cannot serialize a non-trackable part")})
+
+        # Quantity must be a valid integer value
+        try:
+            quantity = int(quantity)
+        except ValueError:
+            raise ValueError({"quantity": _("Quantity must be integer")})
+
+        if quantity <= 0:
+            raise ValueError({"quantity": _("Quantity must be greater than zero")})
+
+        if quantity > self.quantity:
+            raise ValidationError({"quantity": _("Quantity must not exceed stock quantity")})
+
+        if not type(serials) in [list, tuple]:
+            raise ValueError({"serials": _("Serial numbers must be a list of integers")})
+
+        if any([type(i) is not int for i in serials]):
+            raise ValueError({"serials": _("Serial numbers must be a list of integers")})
+
+        if not quantity == len(serials):
+            raise ValueError({"quantity": _("Quantity does not match serial numbers")})
+
+        # Test if each of the serial numbers are valid
+        existing = []
+
+        for serial in serials:
+            if not StockItem.check_serial_number(self.part, serial):
+                existing.append(serial)
+
+        if len(existing) > 0:
+            raise ValidationError({"serials": _("Serial numbers already exist: ") + str(existing)})
+
+        # Create a new stock item for each unique serial number
+        for serial in serials:
+            
+            # Create a copy of this StockItem
+            new_item = StockItem.objects.get(pk=self.pk)
+            new_item.quantity = 1
+            new_item.serial = serial
+            new_item.pk = None
+
+            if location:
+                new_item.location = location
+
+            new_item.save()
+
+            # Copy entire transaction history
+            new_item.copyHistoryFrom(self)
+
+            # Create a new stock tracking item
+            self.addTransactionNote(_('Add serial number'), user)
+
+        # Remove the equivalent number of items
+        self.take_stock(quantity, user, notes=_('Serialized {n} items'.format(n=quantity)))
+
+    @transaction.atomic
+    def copyHistoryFrom(self, other):
+        """ Copy stock history from another part """
+
+        for item in other.tracking_info.all():
+            
+            item.item = self
+            item.pk = None
+            item.save()
 
     @transaction.atomic
     def splitStock(self, quantity, user):
@@ -414,6 +499,9 @@ class StockItem(models.Model):
 
         new_stock.save()
 
+        # Copy the transaction history
+        new_stock.copyHistoryFrom(self)
+
         # Add a new tracking item for the new stock item
         new_stock.addTransactionNote(
             "Split from existing stock",
diff --git a/InvenTree/stock/tests.py b/InvenTree/stock/tests.py
index 417c995b6c..63423ec291 100644
--- a/InvenTree/stock/tests.py
+++ b/InvenTree/stock/tests.py
@@ -1,5 +1,7 @@
 from django.test import TestCase
 from django.db.models import Sum
+from django.contrib.auth import get_user_model
+from django.core.exceptions import ValidationError
 
 from .models import StockLocation, StockItem, StockItemTracking
 from part.models import Part
@@ -28,6 +30,14 @@ class StockTest(TestCase):
         self.drawer2 = StockLocation.objects.get(name='Drawer_2')
         self.drawer3 = StockLocation.objects.get(name='Drawer_3')
 
+        # Create a user
+        User = get_user_model()
+        User.objects.create_user('username', 'user@email.com', 'password')
+
+        self.client.login(username='username', password='password')
+
+        self.user = User.objects.get(username='username')
+
     def test_loc_count(self):
         self.assertEqual(StockLocation.objects.count(), 7)
 
@@ -244,3 +254,71 @@ class StockTest(TestCase):
 
         with self.assertRaises(StockItem.DoesNotExist):
             w2 = StockItem.objects.get(pk=101)
+
+    def test_serialize_stock_invalid(self):
+        """
+        Test manual serialization of parts.
+        Each of these tests should fail
+        """
+
+        # Test serialization of non-serializable part
+        item = StockItem.objects.get(pk=1234)
+
+        with self.assertRaises(ValueError):
+            item.serializeStock(5, [1, 2, 3, 4, 5], self.user)
+
+        # Pick a StockItem which can actually be serialized
+        item = StockItem.objects.get(pk=100)
+
+        # Try an invalid quantity
+        with self.assertRaises(ValueError):
+            item.serializeStock("k", [], self.user)
+
+        with self.assertRaises(ValueError):
+            item.serializeStock(-1, [], self.user)
+
+        # Try invalid serial numbers
+        with self.assertRaises(ValueError):
+            item.serializeStock(3, [1, 2, 'k'], self.user)
+
+        with self.assertRaises(ValueError):
+            item.serializeStock(3, "hello", self.user)
+
+    def test_seiralize_stock_valid(self):
+        """ Perform valid stock serializations """
+
+        # There are 10 of these in stock
+        # Item will deplete when deleted
+        item = StockItem.objects.get(pk=100)
+        item.delete_on_deplete = True
+        item.save()
+
+        n = StockItem.objects.filter(part=25).count()
+
+        self.assertEqual(item.quantity, 10)
+
+        item.serializeStock(3, [1, 2, 3], self.user)
+
+        self.assertEqual(item.quantity, 7)
+
+        # Try to serialize again (with same serial numbers)
+        with self.assertRaises(ValidationError):
+            item.serializeStock(3, [1, 2, 3], self.user)
+
+        # Try to serialize too many items
+        with self.assertRaises(ValidationError):
+            item.serializeStock(13, [1, 2, 3], self.user)
+
+        # Serialize some more stock
+        item.serializeStock(5, [6, 7, 8, 9, 10], self.user)
+
+        self.assertEqual(item.quantity, 2)
+
+        # There should be 8 more items now
+        self.assertEqual(StockItem.objects.filter(part=25).count(), n + 8)
+
+        # Serialize the remainder of the stock
+        item.serializeStock(2, [99, 100], self.user)
+
+        # Two more items but the original has been deleted
+        self.assertEqual(StockItem.objects.filter(part=25).count(), n + 9)

From 3b8f5872ac13c0ea350ced83179889d425fc95d5 Mon Sep 17 00:00:00 2001
From: Oliver Walters <oliver.henry.walters@gmail.com>
Date: Wed, 28 Aug 2019 21:21:26 +1000
Subject: [PATCH 04/11] Add button to serialize stock

---
 InvenTree/stock/templates/stock/item.html | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/InvenTree/stock/templates/stock/item.html b/InvenTree/stock/templates/stock/item.html
index 62e46c8f84..2d59c9f84e 100644
--- a/InvenTree/stock/templates/stock/item.html
+++ b/InvenTree/stock/templates/stock/item.html
@@ -24,6 +24,11 @@
             <button type='button' class='btn btn-default btn-glyph' id='stock-count' title='Count stock'>
                 <span class='glyphicon glyphicon-ok-circle'/>
             </button>
+            {% if item.part.trackable %}
+            <button type='button' class='btn btn-default btn-glyph' id='stock-serialize' title='Serialize stock'>
+                <span class='glyphicon glyphicon-th-list'/>
+            </button>
+            {% endif %}
             {% endif %}
             <button type='button' class='btn btn-default btn-glyph' id='stock-move' title='Transfer stock'>
                 <span class='glyphicon glyphicon-transfer' style='color: #11a;'/>

From 7575a39b7fd18f590da4f555867152500b2770e7 Mon Sep 17 00:00:00 2001
From: Oliver Walters <oliver.henry.walters@gmail.com>
Date: Wed, 28 Aug 2019 21:46:26 +1000
Subject: [PATCH 05/11] Add form / view for serializing a stock item

- Back end doesn't do anything yet
---
 InvenTree/stock/forms.py                      | 33 +++++++++++++++++++
 InvenTree/stock/templates/stock/item.html     |  9 +++++
 .../stock/templates/stock/item_serialize.html |  6 ++++
 InvenTree/stock/urls.py                       |  9 ++---
 InvenTree/stock/views.py                      | 23 +++++++++++++
 5 files changed, 76 insertions(+), 4 deletions(-)
 create mode 100644 InvenTree/stock/templates/stock/item_serialize.html

diff --git a/InvenTree/stock/forms.py b/InvenTree/stock/forms.py
index ecc71f3423..c3acfd436c 100644
--- a/InvenTree/stock/forms.py
+++ b/InvenTree/stock/forms.py
@@ -63,6 +63,39 @@ class CreateStockItemForm(HelperForm):
         self._clean_form()
 
 
+class SerializeStockForm(forms.ModelForm):
+    """ Form for serializing a StockItem. """
+
+    destination = forms.ChoiceField(label='Destination', required=True, help_text='Destination for serialized stock (by default, will remain in current location)')
+    serial_numbers = forms.CharField(label='Serial numbers', required=True, help_text='Unique serial numbers')    
+    note = forms.CharField(label='Notes', required=False, help_text='Add transaction note')
+
+    def get_location_choices(self):
+        locs = StockLocation.objects.all()
+
+        choices = [(None, '---------')]
+
+        for loc in locs:
+            choices.append((loc.pk, loc.pathstring + ' - ' + loc.description))
+
+        return choices
+
+    def __init__(self, *args, **kwargs):
+        super().__init__(*args, **kwargs)
+
+        self.fields['destination'].choices = self.get_location_choices()
+
+    class Meta:
+        model = StockItem
+
+        fields = [
+            'quantity',
+            'serial_numbers',
+            'destination',
+            'note',
+        ]
+
+
 class AdjustStockForm(forms.ModelForm):
     """ Form for performing simple stock adjustments.
 
diff --git a/InvenTree/stock/templates/stock/item.html b/InvenTree/stock/templates/stock/item.html
index 2d59c9f84e..1e7e44046c 100644
--- a/InvenTree/stock/templates/stock/item.html
+++ b/InvenTree/stock/templates/stock/item.html
@@ -167,6 +167,15 @@
         );
     }); 
 
+    $("#stock-serialize").click(function() {
+        launchModalForm(
+            "{% url 'stock-item-serialize' item.id %}",
+            {
+                reload: true,
+            }
+        );
+    });
+
     $("#stock-duplicate").click(function() {
         launchModalForm(
             "{% url 'stock-item-create' %}",
diff --git a/InvenTree/stock/templates/stock/item_serialize.html b/InvenTree/stock/templates/stock/item_serialize.html
new file mode 100644
index 0000000000..bb0054cca2
--- /dev/null
+++ b/InvenTree/stock/templates/stock/item_serialize.html
@@ -0,0 +1,6 @@
+{% extends "modal_form.html" %}
+
+{% block pre_form_content %}
+Create serialized items from this stock item.<br>
+Select quantity to serialize, and unique serial numbers.
+{% endblock %}
\ No newline at end of file
diff --git a/InvenTree/stock/urls.py b/InvenTree/stock/urls.py
index 9e17d568cf..76fbaae669 100644
--- a/InvenTree/stock/urls.py
+++ b/InvenTree/stock/urls.py
@@ -17,11 +17,12 @@ stock_location_detail_urls = [
 ]
 
 stock_item_detail_urls = [
-    url(r'^edit/?', views.StockItemEdit.as_view(), name='stock-item-edit'),
-    url(r'^delete/?', views.StockItemDelete.as_view(), name='stock-item-delete'),
-    url(r'^qr_code/?', views.StockItemQRCode.as_view(), name='stock-item-qr'),
+    url(r'^edit/', views.StockItemEdit.as_view(), name='stock-item-edit'),
+    url(r'^serialize/', views.StockItemSerialize.as_view(), name='stock-item-serialize'),
+    url(r'^delete/', views.StockItemDelete.as_view(), name='stock-item-delete'),
+    url(r'^qr_code/', views.StockItemQRCode.as_view(), name='stock-item-qr'),
 
-    url(r'^add_tracking/?', views.StockItemTrackingCreate.as_view(), name='stock-tracking-create'),
+    url(r'^add_tracking/', views.StockItemTrackingCreate.as_view(), name='stock-tracking-create'),
 
     url('^.*$', views.StockItemDetail.as_view(), name='stock-item-detail'),
 ]
diff --git a/InvenTree/stock/views.py b/InvenTree/stock/views.py
index 4ad10d1ada..3c056dc73a 100644
--- a/InvenTree/stock/views.py
+++ b/InvenTree/stock/views.py
@@ -29,6 +29,7 @@ from .forms import CreateStockItemForm
 from .forms import EditStockItemForm
 from .forms import AdjustStockForm
 from .forms import TrackingEntryForm
+from .forms import SerializeStockForm
 
 
 class StockIndex(ListView):
@@ -461,6 +462,28 @@ class StockLocationCreate(AjaxCreateView):
         return initials
 
 
+class StockItemSerialize(AjaxView, FormMixin):
+    """ View for manually serializing a StockItem """
+
+    ajax_template_name = 'stock/item_serialize.html'
+    ajax_form_title = 'Serialize Stock'
+    form_class = SerializeStockForm
+
+    def get(self, request, *args, **kwargs):
+        
+        return super().get(request, *args, **kwargs)
+
+    def post(self, request, *args, **kwargs):
+
+        form = self.get_form()
+
+        data = {
+            'form_valid': False,
+        }
+
+        return self.renderJsonResponse(request, form, data=data)
+
+
 class StockItemCreate(AjaxCreateView):
     """
     View for creating a new StockItem

From 6c5b09efd42fc5944ad04be3be5abc9e5dac354b Mon Sep 17 00:00:00 2001
From: Oliver Walters <oliver.henry.walters@gmail.com>
Date: Wed, 28 Aug 2019 21:50:44 +1000
Subject: [PATCH 06/11] Provide initial data

---
 InvenTree/stock/views.py | 14 +++++++++++++-
 1 file changed, 13 insertions(+), 1 deletion(-)

diff --git a/InvenTree/stock/views.py b/InvenTree/stock/views.py
index 3c056dc73a..5b1f64192f 100644
--- a/InvenTree/stock/views.py
+++ b/InvenTree/stock/views.py
@@ -462,13 +462,25 @@ class StockLocationCreate(AjaxCreateView):
         return initials
 
 
-class StockItemSerialize(AjaxView, FormMixin):
+class StockItemSerialize(AjaxUpdateView):
     """ View for manually serializing a StockItem """
 
+    model = StockItem
     ajax_template_name = 'stock/item_serialize.html'
     ajax_form_title = 'Serialize Stock'
     form_class = SerializeStockForm
 
+    def get_initial(self):
+
+        initials = super().get_initial().copy()
+
+        item = self.get_object()
+
+        initials['quantity'] = item.quantity
+        initials['destination'] = item.location.pk
+
+        return initials
+
     def get(self, request, *args, **kwargs):
         
         return super().get(request, *args, **kwargs)

From 15b38000d576386c313d317e75267662bca96385 Mon Sep 17 00:00:00 2001
From: Oliver Walters <oliver.henry.walters@gmail.com>
Date: Wed, 28 Aug 2019 22:03:40 +1000
Subject: [PATCH 07/11] Improved serial number extraction

- Check data types
- Translation for error messages
---
 InvenTree/InvenTree/helpers.py | 24 +++++++++++++++++-------
 1 file changed, 17 insertions(+), 7 deletions(-)

diff --git a/InvenTree/InvenTree/helpers.py b/InvenTree/InvenTree/helpers.py
index a34199d38c..887b443544 100644
--- a/InvenTree/InvenTree/helpers.py
+++ b/InvenTree/InvenTree/helpers.py
@@ -131,11 +131,21 @@ def ExtractSerialNumbers(serials, expected_quantity):
         expected_quantity: The number of (unique) serial numbers we expect
     """
 
+    serials = serials.strip()
+
     groups = re.split("[\s,]+", serials)
 
     numbers = []
     errors = []
 
+    try:
+        expected_quantity = int(expected_quantity)
+    except ValueError:
+        raise ValidationError([_("Invalid quantity provided")])
+
+    if len(serials) == 0:
+        raise ValidationError([_("Empty serial number string")])
+
     for group in groups:
 
         group = group.strip()
@@ -155,34 +165,34 @@ def ExtractSerialNumbers(serials, expected_quantity):
                     if a < b:
                         for n in range(a, b + 1):
                             if n in numbers:
-                                errors.append('Duplicate serial: {n}'.format(n=n))
+                                errors.append(_('Duplicate serial: {n}'.format(n=n)))
                             else:
                                 numbers.append(n)
                     else:
-                        errors.append("Invalid group: {g}".format(g=group))
+                        errors.append(_("Invalid group: {g}".format(g=group)))
 
                 except ValueError:
-                    errors.append("Invalid group: {g}".format(g=group))
+                    errors.append(_("Invalid group: {g}".format(g=group)))
                     continue
             else:
-                errors.append("Invalid group: {g}".format(g=group))
+                errors.append(_("Invalid group: {g}".format(g=group)))
                 continue
 
         else:
             try:
                 n = int(group)
                 if n in numbers:
-                    errors.append("Duplicate serial: {n}".format(n=n))
+                    errors.append(_("Duplicate serial: {n}".format(n=n)))
                 else:
                     numbers.append(n)
             except ValueError:
-                errors.append("Invalid group: {g}".format(g=group))
+                errors.append(_("Invalid group: {g}".format(g=group)))
 
     if len(errors) > 0:
         raise ValidationError(errors)
 
     if len(numbers) == 0:
-        raise ValidationError(["No serial numbers found"])
+        raise ValidationError([_("No serial numbers found")])
 
     # The number of extracted serial numbers must match the expected quantity
     if not expected_quantity == len(numbers):

From 76ec44d770e77ca2b7ea83af90569f98dbccc208 Mon Sep 17 00:00:00 2001
From: Oliver Walters <oliver.henry.walters@gmail.com>
Date: Wed, 28 Aug 2019 22:04:04 +1000
Subject: [PATCH 08/11] Form improvements

---
 InvenTree/stock/forms.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/InvenTree/stock/forms.py b/InvenTree/stock/forms.py
index c3acfd436c..e03f84a339 100644
--- a/InvenTree/stock/forms.py
+++ b/InvenTree/stock/forms.py
@@ -67,8 +67,8 @@ class SerializeStockForm(forms.ModelForm):
     """ Form for serializing a StockItem. """
 
     destination = forms.ChoiceField(label='Destination', required=True, help_text='Destination for serialized stock (by default, will remain in current location)')
-    serial_numbers = forms.CharField(label='Serial numbers', required=True, help_text='Unique serial numbers')    
-    note = forms.CharField(label='Notes', required=False, help_text='Add transaction note')
+    serial_numbers = forms.CharField(label='Serial numbers', required=True, help_text='Unique serial numbers (must match quantity)')    
+    note = forms.CharField(label='Notes', required=False, help_text='Add transaction note (optional)')
 
     def get_location_choices(self):
         locs = StockLocation.objects.all()

From 4db345d0c2ee4d03578f34a5d272b3ab172cd892 Mon Sep 17 00:00:00 2001
From: Oliver Walters <oliver.henry.walters@gmail.com>
Date: Wed, 28 Aug 2019 22:47:46 +1000
Subject: [PATCH 09/11] Perfom serialization

---
 InvenTree/stock/models.py | 23 ++++++++++-------------
 InvenTree/stock/views.py  | 37 ++++++++++++++++++++++++++++++++++++-
 2 files changed, 46 insertions(+), 14 deletions(-)

diff --git a/InvenTree/stock/models.py b/InvenTree/stock/models.py
index 86b1c7b2b9..00a55629e4 100644
--- a/InvenTree/stock/models.py
+++ b/InvenTree/stock/models.py
@@ -373,7 +373,7 @@ class StockItem(models.Model):
         track.save()
 
     @transaction.atomic
-    def serializeStock(self, quantity, serials, user, location=None):
+    def serializeStock(self, quantity, serials, user, notes=None, location=None):
         """ Split this stock item into unique serial numbers.
 
         - Quantity can be less than or equal to the quantity of the stock item
@@ -384,6 +384,7 @@ class StockItem(models.Model):
             quantity: Number of items to serialize (integer)
             serials: List of serial numbers (list<int>)
             user: User object associated with action
+            notes: Optional notes for tracking
             location: If specified, serialized items will be placed in the given location
         """
 
@@ -391,30 +392,26 @@ class StockItem(models.Model):
         if self.serialized:
             return
 
-        # Do not serialize non-trackable parts
-        if not self.part.trackable:
-            raise ValueError({"part": _("Cannot serialize a non-trackable part")})
-
         # Quantity must be a valid integer value
         try:
             quantity = int(quantity)
         except ValueError:
-            raise ValueError({"quantity": _("Quantity must be integer")})
+            raise ValidationError({"quantity": _("Quantity must be integer")})
 
         if quantity <= 0:
-            raise ValueError({"quantity": _("Quantity must be greater than zero")})
+            raise ValidationError({"quantity": _("Quantity must be greater than zero")})
 
         if quantity > self.quantity:
-            raise ValidationError({"quantity": _("Quantity must not exceed stock quantity")})
+            raise ValidationError({"quantity": _("Quantity must not exceed available stock quantity ({n})".format(n=self.quantity))})
 
         if not type(serials) in [list, tuple]:
-            raise ValueError({"serials": _("Serial numbers must be a list of integers")})
+            raise ValidationError({"serial_numbers": _("Serial numbers must be a list of integers")})
 
         if any([type(i) is not int for i in serials]):
-            raise ValueError({"serials": _("Serial numbers must be a list of integers")})
+            raise ValidationError({"serial_numbers": _("Serial numbers must be a list of integers")})
 
         if not quantity == len(serials):
-            raise ValueError({"quantity": _("Quantity does not match serial numbers")})
+            raise ValidationError({"quantity": _("Quantity does not match serial numbers")})
 
         # Test if each of the serial numbers are valid
         existing = []
@@ -424,7 +421,7 @@ class StockItem(models.Model):
                 existing.append(serial)
 
         if len(existing) > 0:
-            raise ValidationError({"serials": _("Serial numbers already exist: ") + str(existing)})
+            raise ValidationError({"serial_numbers": _("Serial numbers already exist: ") + str(existing)})
 
         # Create a new stock item for each unique serial number
         for serial in serials:
@@ -444,7 +441,7 @@ class StockItem(models.Model):
             new_item.copyHistoryFrom(self)
 
             # Create a new stock tracking item
-            self.addTransactionNote(_('Add serial number'), user)
+            new_item.addTransactionNote(_('Add serial number'), user, notes=notes)
 
         # Remove the equivalent number of items
         self.take_stock(quantity, user, notes=_('Serialized {n} items'.format(n=quantity)))
diff --git a/InvenTree/stock/views.py b/InvenTree/stock/views.py
index 5b1f64192f..4ecceac3fb 100644
--- a/InvenTree/stock/views.py
+++ b/InvenTree/stock/views.py
@@ -489,8 +489,43 @@ class StockItemSerialize(AjaxUpdateView):
 
         form = self.get_form()
 
+        item = self.get_object()
+
+        quantity = request.POST.get('quantity', None)
+        serials = request.POST.get('serial_numbers', '')
+        dest_id = request.POST.get('destination', None)
+        notes = request.POST.get('note', None)
+        user = request.user
+
+        valid = True
+
+        try:
+            destination = StockLocation.objects.get(pk=dest_id)
+        except (ValueError, StockLocation.DoesNotExist):
+            destination = None
+
+        try:
+            numbers = ExtractSerialNumbers(serials, quantity)
+        except ValidationError as e:
+            form.errors['serial_numbers'] = e.messages
+            valid = False
+        
+        if valid:
+            try:
+                item.serializeStock(quantity, numbers, user, notes=notes, location=destination)
+            except ValidationError as e:
+                messages = e.message_dict
+                
+                for k in messages.keys():
+                    if k in ['quantity', 'destionation', 'serial_numbers']:
+                        form.errors[k] = messages[k]
+                    else:
+                        form.non_field_errors = messages[k]
+
+                valid = False
+
         data = {
-            'form_valid': False,
+            'form_valid': valid,
         }
 
         return self.renderJsonResponse(request, form, data=data)

From 937bcd41d65396a2fed2909e3f6c7ffc7684feeb Mon Sep 17 00:00:00 2001
From: Oliver Walters <oliver.henry.walters@gmail.com>
Date: Thu, 29 Aug 2019 07:37:44 +1000
Subject: [PATCH 10/11] Fix tests for stock serialization

---
 InvenTree/stock/forms.py  |  2 +-
 InvenTree/stock/models.py |  3 ++-
 InvenTree/stock/tests.py  | 10 +++++-----
 3 files changed, 8 insertions(+), 7 deletions(-)

diff --git a/InvenTree/stock/forms.py b/InvenTree/stock/forms.py
index e03f84a339..02c52defe1 100644
--- a/InvenTree/stock/forms.py
+++ b/InvenTree/stock/forms.py
@@ -67,7 +67,7 @@ class SerializeStockForm(forms.ModelForm):
     """ Form for serializing a StockItem. """
 
     destination = forms.ChoiceField(label='Destination', required=True, help_text='Destination for serialized stock (by default, will remain in current location)')
-    serial_numbers = forms.CharField(label='Serial numbers', required=True, help_text='Unique serial numbers (must match quantity)')    
+    serial_numbers = forms.CharField(label='Serial numbers', required=True, help_text='Unique serial numbers (must match quantity)')
     note = forms.CharField(label='Notes', required=False, help_text='Add transaction note (optional)')
 
     def get_location_choices(self):
diff --git a/InvenTree/stock/models.py b/InvenTree/stock/models.py
index 00a55629e4..9aa8595c49 100644
--- a/InvenTree/stock/models.py
+++ b/InvenTree/stock/models.py
@@ -359,6 +359,7 @@ class StockItem(models.Model):
 
         Brief automated note detailing a movement or quantity change.
         """
+        
         track = StockItemTracking.objects.create(
             item=self,
             title=title,
@@ -373,7 +374,7 @@ class StockItem(models.Model):
         track.save()
 
     @transaction.atomic
-    def serializeStock(self, quantity, serials, user, notes=None, location=None):
+    def serializeStock(self, quantity, serials, user, notes='', location=None):
         """ Split this stock item into unique serial numbers.
 
         - Quantity can be less than or equal to the quantity of the stock item
diff --git a/InvenTree/stock/tests.py b/InvenTree/stock/tests.py
index 63423ec291..bc92a4c056 100644
--- a/InvenTree/stock/tests.py
+++ b/InvenTree/stock/tests.py
@@ -264,24 +264,24 @@ class StockTest(TestCase):
         # Test serialization of non-serializable part
         item = StockItem.objects.get(pk=1234)
 
-        with self.assertRaises(ValueError):
+        with self.assertRaises(ValidationError):
             item.serializeStock(5, [1, 2, 3, 4, 5], self.user)
 
         # Pick a StockItem which can actually be serialized
         item = StockItem.objects.get(pk=100)
 
         # Try an invalid quantity
-        with self.assertRaises(ValueError):
+        with self.assertRaises(ValidationError):
             item.serializeStock("k", [], self.user)
 
-        with self.assertRaises(ValueError):
+        with self.assertRaises(ValidationError):
             item.serializeStock(-1, [], self.user)
 
         # Try invalid serial numbers
-        with self.assertRaises(ValueError):
+        with self.assertRaises(ValidationError):
             item.serializeStock(3, [1, 2, 'k'], self.user)
 
-        with self.assertRaises(ValueError):
+        with self.assertRaises(ValidationError):
             item.serializeStock(3, "hello", self.user)
 
     def test_seiralize_stock_valid(self):

From 86b2b9cdb1ba48825e42bbbf3634cfdcbdd56bd9 Mon Sep 17 00:00:00 2001
From: Oliver Walters <oliver.henry.walters@gmail.com>
Date: Thu, 29 Aug 2019 08:05:45 +1000
Subject: [PATCH 11/11] Allow unserialized build

---
 InvenTree/build/forms.py |  8 +++++---
 InvenTree/build/views.py | 32 ++++++++++++++++++--------------
 2 files changed, 23 insertions(+), 17 deletions(-)

diff --git a/InvenTree/build/forms.py b/InvenTree/build/forms.py
index 101903e1e8..54f651eade 100644
--- a/InvenTree/build/forms.py
+++ b/InvenTree/build/forms.py
@@ -5,6 +5,8 @@ Django Forms for interacting with Build objects
 # -*- coding: utf-8 -*-
 from __future__ import unicode_literals
 
+from django.utils.translation import ugettext as _
+
 from InvenTree.forms import HelperForm
 from django import forms
 from .models import Build, BuildItem
@@ -31,7 +33,7 @@ class EditBuildForm(HelperForm):
 class ConfirmBuildForm(HelperForm):
     """ Form for auto-allocation of stock to a build """
 
-    confirm = forms.BooleanField(required=False, help_text='Confirm')
+    confirm = forms.BooleanField(required=False, help_text=_('Confirm'))
 
     class Meta:
         model = Build
@@ -48,9 +50,9 @@ class CompleteBuildForm(HelperForm):
         help_text='Location of completed parts',
     )
 
-    serial_numbers = forms.CharField(label='Serial numbers', help_text='Enter unique serial numbers')
+    serial_numbers = forms.CharField(label='Serial numbers', required=False, help_text=_('Enter unique serial numbers (or leave blank)'))
 
-    confirm = forms.BooleanField(required=False, help_text='Confirm build submission')
+    confirm = forms.BooleanField(required=False, help_text=_('Confirm build completion'))
 
     class Meta:
         model = Build
diff --git a/InvenTree/build/views.py b/InvenTree/build/views.py
index 7a1dceaf23..4fa6be696a 100644
--- a/InvenTree/build/views.py
+++ b/InvenTree/build/views.py
@@ -270,25 +270,29 @@ class BuildComplete(AjaxUpdateView):
 
                 sn = request.POST.get('serial_numbers', '')
 
-                try:
-                    # Exctract a list of provided serial numbers
-                    serials = ExtractSerialNumbers(sn, build.quantity)
+                sn = str(sn).strip()
 
-                    existing = []
+                # If the user has specified serial numbers, check they are valid
+                if len(sn) > 0:
+                    try:
+                        # Exctract a list of provided serial numbers
+                        serials = ExtractSerialNumbers(sn, build.quantity)
 
-                    for serial in serials:
-                        if not StockItem.check_serial_number(build.part, serial):
-                            existing.append(serial)
+                        existing = []
 
-                    if len(existing) > 0:
-                        exists = ",".join([str(x) for x in existing])
-                        form.errors['serial_numbers'] = [_('The following serial numbers already exist: ({sn})'.format(sn=exists))]
+                        for serial in serials:
+                            if not StockItem.check_serial_number(build.part, serial):
+                                existing.append(serial)
+
+                        if len(existing) > 0:
+                            exists = ",".join([str(x) for x in existing])
+                            form.errors['serial_numbers'] = [_('The following serial numbers already exist: ({sn})'.format(sn=exists))]
+                            valid = False
+
+                    except ValidationError as e:
+                        form.errors['serial_numbers'] = e.messages
                         valid = False
 
-                except ValidationError as e:
-                    form.errors['serial_numbers'] = e.messages
-                    valid = False
-
             if valid:
                 build.completeBuild(location, serials, request.user)