mirror of
https://github.com/inventree/InvenTree.git
synced 2026-11-20 06:57:57 +00:00
fix(backend): preserve redirect target through /accounts/login/ (#13279)
AuthRequiredMiddleware redirects unauthenticated requests for server-rendered paths to /accounts/login/?next=<path>, but the account_login redirect view then bounced straight to the frontend root, dropping the target. Forward a safe relative 'next' parameter to the SPA's /logged-in page instead, where LoggedIn.tsx recovers it once the login flow completes. Absolute or protocol-relative targets are dropped to rule out open redirects.
This commit is contained in:
1 parent
ed0bbc3c75
commit
80ad822688
4 files changed
+95
-5
No files matched your search
@@ -135,6 +135,29 @@ test('SSO - Complete Registration', async ({ page }) => {
|
||||
.waitFor();
|
||||
});
|
||||
|
||||
test('SSO - Deep Link Redirect Target', async ({ page }) => {
|
||||
// A CUI deep link visited while logged out must return the user to the
|
||||
// requested page after logging in via SSO
|
||||
await setSettingState({ setting: 'LOGIN_ENABLE_SSO', value: true });
|
||||
await setSettingState({ setting: 'LOGIN_ENABLE_SSO_REG', value: true });
|
||||
await setSettingState({ setting: 'LOGIN_SIGNUP_SSO_AUTO', value: true });
|
||||
|
||||
await navigate(page, logoutUrl, { waitUntil: 'load' });
|
||||
await page.waitForURL('**/web/login');
|
||||
|
||||
// The CUI compatibility redirect only exists on the backend
|
||||
const backendUrl = new URL('/', apiUrl).toString();
|
||||
|
||||
await page.goto(`${backendUrl}part/3/`, { waitUntil: 'load' });
|
||||
await page.waitForURL('**/web/login');
|
||||
|
||||
await page.getByRole('button', { name: 'Mock SSO' }).click();
|
||||
|
||||
// Back on the originally requested part
|
||||
await page.waitForURL(/\/web\/part\/3(\/|$)/);
|
||||
await page.getByRole('button', { name: 'navigation-menu' }).waitFor();
|
||||
});
|
||||
|
||||
test('SSO - Registration Disabled', async ({ page }) => {
|
||||
// Allow SSO login, but disable self-registration - a brand-new SSO
|
||||
// identity has no matching local account, and nothing should silently
|
||||
|
||||
Reference in new issue
Block a user