From 84bfffd5a716531956607006805031b617d62964 Mon Sep 17 00:00:00 2001 From: Oliver Walters Date: Tue, 11 May 2021 22:51:29 +1000 Subject: [PATCH] Override 'add_note' when new StockItem is created - This allows us to prevent the issue of duplicate notes being created --- InvenTree/order/models.py | 2 +- InvenTree/stock/models.py | 5 ++++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/InvenTree/order/models.py b/InvenTree/order/models.py index ddb1f5ceea..5305038b4f 100644 --- a/InvenTree/order/models.py +++ b/InvenTree/order/models.py @@ -366,7 +366,7 @@ class PurchaseOrder(Order): purchase_price=purchase_price, ) - stock.save() + stock.save(add_note=False) tracking_info = { 'status': status, diff --git a/InvenTree/stock/models.py b/InvenTree/stock/models.py index ac870fad75..4076b27c97 100644 --- a/InvenTree/stock/models.py +++ b/InvenTree/stock/models.py @@ -183,9 +183,12 @@ class StockItem(MPTTModel): self.validate_unique() self.clean() + # If 'add_note = False' specified, then no tracking note will be added for item creation + add_note = kwargs.pop('add_note', True) + if not self.pk: # StockItem has not yet been saved - add_note = True + add_note = add_note and True else: # StockItem has already been saved add_note = False