inventree/InvenTree
2
0
Fork 0
mirror of https://github.com/inventree/InvenTree.git synced 2025-07-02 11:40:58 +00:00
Code Activity

Adds callback for creation of an error log (#3136)

Browse Source 
* Adds callback for creation of an error log

* Fix unit tests
This commit is contained in:
Oliver
2022-06-06 15:21:31 +10:00
committed by GitHub
parent a066fcc909
commit 92aa7adfec
3 changed files with 44 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
InvenTree/common/notifications.py
View File

@ -299,11 +299,12 @@ def trigger_notification(obj, category=None, obj_ref='pk', **kwargs):
delivery_methods = (delivery_methods - IGNORED_NOTIFICATION_CLS)
for method in delivery_methods:
logger.info(f"Triggering method '{method.METHOD_NAME}'")
logger.info(f"Triggering notification method '{method.METHOD_NAME}'")
try:
deliver_notification(method, obj, category, targets, context)
except NotImplementedError as error:
raise error
# Allow any single notification method to fail, without failing the others
logger.error(error)
except Exception as error:
logger.error(error)

4
InvenTree/common/test_notifications.py
View File

@ -93,7 +93,7 @@ class BulkNotificationMethodTests(BaseNotificationIntegrationTest):
def get_targets(self):
return [1, ]
with self.assertRaises(NotImplementedError):
with self.assertLogs(logger='inventree', level='ERROR'):
self._notification_run(WrongImplementation)
@ -115,7 +115,7 @@ class SingleNotificationMethodTests(BaseNotificationIntegrationTest):
def get_targets(self):
return [1, ]
with self.assertRaises(NotImplementedError):
with self.assertLogs(logger='inventree', level='ERROR'):
self._notification_run(WrongImplementation)
# A integration test for notifications is provided in test_part.PartNotificationTest