From 9beefd09f75e32066be2e91c64f84e8f055a1b0b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mikl=C3=B3s=20M=C3=A1rton?= Date: Mon, 31 Oct 2022 01:28:49 +0100 Subject: [PATCH] Remove special character restrictions in parameter template names (#3883) * Remove special character restrictions in parameter template names Fixes #3852 * Added migration --- .../0088_alter_partparametertemplate_name.py | 18 ++++++++++++++++++ InvenTree/part/models.py | 10 ++-------- 2 files changed, 20 insertions(+), 8 deletions(-) create mode 100644 InvenTree/part/migrations/0088_alter_partparametertemplate_name.py diff --git a/InvenTree/part/migrations/0088_alter_partparametertemplate_name.py b/InvenTree/part/migrations/0088_alter_partparametertemplate_name.py new file mode 100644 index 0000000000..b00679820c --- /dev/null +++ b/InvenTree/part/migrations/0088_alter_partparametertemplate_name.py @@ -0,0 +1,18 @@ +# Generated by Django 3.2.16 on 2022-10-30 23:06 + +from django.db import migrations, models + + +class Migration(migrations.Migration): + + dependencies = [ + ('part', '0087_bomitem_consumable'), + ] + + operations = [ + migrations.AlterField( + model_name='partparametertemplate', + name='name', + field=models.CharField(help_text='Parameter Name', max_length=100, unique=True, verbose_name='Name'), + ), + ] diff --git a/InvenTree/part/models.py b/InvenTree/part/models.py index 55870b78d6..fb68875a91 100644 --- a/InvenTree/part/models.py +++ b/InvenTree/part/models.py @@ -2383,10 +2383,7 @@ class PartTestTemplate(models.Model): def validate_template_name(name): - """Prevent illegal characters in "name" field for PartParameterTemplate.""" - for c in "\"\'`!?|": # noqa: P103 - if c in str(name): - raise ValidationError(_(f"Illegal character in template name ({c})")) + """Placeholder for legacy function used in migrations.""" class PartParameterTemplate(models.Model): @@ -2431,10 +2428,7 @@ class PartParameterTemplate(models.Model): max_length=100, verbose_name=_('Name'), help_text=_('Parameter Name'), - unique=True, - validators=[ - validate_template_name, - ] + unique=True ) units = models.CharField(max_length=25, verbose_name=_('Units'), help_text=_('Parameter Units'), blank=True)