From a4d16f3621081ae1ea0551feb9cb0ff5e7b54356 Mon Sep 17 00:00:00 2001 From: Oliver Walters Date: Wed, 26 Nov 2025 05:54:46 +0000 Subject: [PATCH] More fixes --- src/backend/InvenTree/part/models.py | 8 ++++---- src/backend/InvenTree/part/test_category.py | 2 +- src/backend/InvenTree/part/test_param.py | 2 -- 3 files changed, 5 insertions(+), 7 deletions(-) diff --git a/src/backend/InvenTree/part/models.py b/src/backend/InvenTree/part/models.py index db10a21557..207f094e50 100644 --- a/src/backend/InvenTree/part/models.py +++ b/src/backend/InvenTree/part/models.py @@ -226,7 +226,7 @@ class PartCategory( """Prefectch parts parameters.""" return ( self.get_parts(cascade=cascade) - .prefetch_related('parameters', 'parameters__template') + .prefetch_related('parameters_list', 'parameters_list__template') .all() ) @@ -237,7 +237,7 @@ class PartCategory( parts = prefetch or self.prefetch_parts_parameters(cascade=cascade) for part in parts: - for parameter in part.parameters.all(): + for parameter in part.parameters_list.all(): parameter_name = parameter.template.name if parameter_name not in unique_parameters_names: unique_parameters_names.append(parameter_name) @@ -260,7 +260,7 @@ class PartCategory( if part.IPN: part_parameters['IPN'] = part.IPN - for parameter in part.parameters.all(): + for parameter in part.parameters_list.all(): parameter_name = parameter.template.name parameter_value = parameter.data part_parameters[parameter_name] = parameter_value @@ -3763,7 +3763,7 @@ class PartCategoryParameterTemplate(InvenTree.models.InvenTreeMetadataModel): if ( self.default_value and get_global_setting( - 'PART_PARAMETER_ENFORCE_UNITS', True, cache=False, create=False + 'PARAMETER_ENFORCE_UNITS', True, cache=False, create=False ) and self.template.units ): diff --git a/src/backend/InvenTree/part/test_category.py b/src/backend/InvenTree/part/test_category.py index 85d6d6c246..a5bb5e6a2d 100644 --- a/src/backend/InvenTree/part/test_category.py +++ b/src/backend/InvenTree/part/test_category.py @@ -163,7 +163,7 @@ class CategoryTest(TestCase): # Iterate through all parts and parameters for fastener in fasteners: self.assertIsInstance(fastener, Part) - for parameter in fastener.parameters.all(): + for parameter in fastener.parameters_list.all(): self.assertIsInstance(parameter, Parameter) self.assertIsInstance(parameter.template, ParameterTemplate) diff --git a/src/backend/InvenTree/part/test_param.py b/src/backend/InvenTree/part/test_param.py index 2e77055ec0..4e3bae3a70 100644 --- a/src/backend/InvenTree/part/test_param.py +++ b/src/backend/InvenTree/part/test_param.py @@ -249,8 +249,6 @@ class ParameterTests(TestCase): bad_values = ['3 Amps', '-3 zogs', '3.14F'] - raise ValueError('This test must be refactored...') - # Disable enforcing of part parameter units InvenTreeSetting.set_setting('PARAMETER_ENFORCE_UNITS', False, change_user=None)