inventree/InvenTree
2
0
Fork 0
mirror of https://github.com/inventree/InvenTree.git synced 2025-04-28 19:46:46 +00:00
Code

Fix APICallMixin url_args handling (#6468)

Browse Source
This commit is contained in:
Bobbe 2024-02-11 22:01:28 +01:00 committed by GitHub
parent 824aa8138b
commit b372db8960
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 13 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
InvenTree/plugin/base/integration/APICallMixin.py
View File

@ -2,6 +2,7 @@
import json as json_pkg import json as json_pkg
import logging import logging
from collections.abc import Iterable
import requests import requests
@ -107,7 +108,9 @@ class APICallMixin:
"""Returns an encoded path for the provided dict.""" """Returns an encoded path for the provided dict."""
groups = [] groups = []
for key, val in arguments.items(): for key, val in arguments.items():
groups.append(f'{key}={",".join([str(a) for a in val])}') if isinstance(val, Iterable) and not isinstance(val, str):
val = ','.join([str(a) for a in val])
groups.append(f'{key}={val}')
return f'?{"&".join(groups)}' return f'?{"&".join(groups)}'
def api_call( def api_call(

15
InvenTree/plugin/base/integration/test_mixins.py
View File

@ -263,14 +263,17 @@ class APICallMixinTest(BaseMixinDefinition, TestCase):
"""Test that building up args work.""" """Test that building up args work."""
# api_build_url_args # api_build_url_args
# 1 arg # 1 arg
result = self.mixin.api_build_url_args({'a': 'b'}) result = self.mixin.api_build_url_args({'a': 'abc123'})
self.assertEqual(result, '?a=b') self.assertEqual(result, '?a=abc123')
# non string arg
result = self.mixin.api_build_url_args({'a': 1})
self.assertEqual(result, '?a=1')
# more args # more args
result = self.mixin.api_build_url_args({'a': 'b', 'c': 'd'}) result = self.mixin.api_build_url_args({'a': 'b', 'c': 42})
self.assertEqual(result, '?a=b&c=d') self.assertEqual(result, '?a=b&c=42')
# list args # list args
result = self.mixin.api_build_url_args({'a': 'b', 'c': ['d', 'e', 'f']}) result = self.mixin.api_build_url_args({'a': 'b', 'c': ['d', 'efgh', 1337]})
self.assertEqual(result, '?a=b&c=d,e,f') self.assertEqual(result, '?a=b&c=d,efgh,1337')
def test_api_call(self): def test_api_call(self):
"""Test that api calls work.""" """Test that api calls work."""