From b88a6ccdb578addbed5c1508d50fcb42bd1df284 Mon Sep 17 00:00:00 2001 From: Matthias Date: Sat, 12 Mar 2022 03:35:20 +0100 Subject: [PATCH] test default value with as_int and fix it --- InvenTree/common/models.py | 2 +- InvenTree/common/tests.py | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/InvenTree/common/models.py b/InvenTree/common/models.py index 2b84918e82..22afb80664 100644 --- a/InvenTree/common/models.py +++ b/InvenTree/common/models.py @@ -570,7 +570,7 @@ class BaseInvenTreeSetting(models.Model): try: value = int(self.value) except (ValueError, TypeError): - value = self.default_value() + value = self.default_value return value diff --git a/InvenTree/common/tests.py b/InvenTree/common/tests.py index a226e57a5d..77a4f1a12d 100644 --- a/InvenTree/common/tests.py +++ b/InvenTree/common/tests.py @@ -88,6 +88,7 @@ class SettingsTest(TestCase): # check as_int self.assertEqual(stale_days.as_int(), 0) + self.assertEqual(instance_obj.as_int(), 'InvenTree server') # not an int -> return default # check as_bool self.assertEqual(report_test_obj.as_bool(), True)