From bbeaf0e791dadcfdc77aef9ce1242d5043d1e680 Mon Sep 17 00:00:00 2001 From: Matthias Mair Date: Mon, 27 Jan 2025 09:52:05 +0100 Subject: [PATCH] feat(backend): Improve error with missing manifest (#8957) * package tag results better * Add docs for missing frontend * better error indication Fixes #8875 * fix test assertations * fix test exception * group setup admin stuff * add operations supgourp * add basic structure * move error code * fix link * fix grammar issues --- docs/docs/faq.md | 5 ++++ docs/docs/settings/error_codes.md | 26 +++++++++++++++++++ docs/mkdocs.yml | 17 +++++++----- .../InvenTree/web/templates/web/index.html | 14 ++++++++-- .../InvenTree/web/templatetags/spa_helper.py | 4 +-- src/backend/InvenTree/web/tests.py | 7 +++-- 6 files changed, 58 insertions(+), 15 deletions(-) create mode 100644 docs/docs/settings/error_codes.md diff --git a/docs/docs/faq.md b/docs/docs/faq.md index 1cf0cfe710..62e68cb90e 100644 --- a/docs/docs/faq.md +++ b/docs/docs/faq.md @@ -26,6 +26,11 @@ Refer to the [invoke guide](./start/invoke.md#cant-find-any-collection-named-tas If the installed version of invoke is too old, users may see error messages during the installation procedure. Refer to the [invoke guide](./start/invoke.md#minimum-version) for more information. +### INVE-E1 - No frontend included + +Make sure you are running a stable or production release of InvenTree. The frontend panel is not included in development releases. +More Information: [Error Codes - INVE-E1](./settings/error_codes.md#inve-e1) + ### No module named During the install or update process, you may be presented with an error like: diff --git a/docs/docs/settings/error_codes.md b/docs/docs/settings/error_codes.md new file mode 100644 index 0000000000..5fe8076c15 --- /dev/null +++ b/docs/docs/settings/error_codes.md @@ -0,0 +1,26 @@ +## Error Codes + +InvenTree is starting to use error codes to help identify and diagnose issues. These are increasingly being added to the codebase. Error messages missing an error code should be reported on GitHub. +Error codes are prefixed with `INVE-` and are followed by a letter to indicate the type of error and a number to indicate the specific error. Once a code is used it might not be reassigned to a different error, it can be marked as stricken from the list. + +### INVE-E (InvenTree Error) +Errors - These are critical errors which should be addressed as soon as possible. + +#### INVE-E1 +**No frontend included - Backend/web** + +Only stable / production releases of InvenTree include the frontend panel. This is both a measure of resource-saving and attack surface reduction. If you want to use the frontend panel, you can either:″ +- use a docker image that is version-tagged or the stable version +- use a package version that is from the stable or version stream +- install node and yarn on the server to build the frontend with the [invoke](../start/invoke.md) task `int.frontend-build` + +Raise an issue if none of these options work. + +### INVE-W (InvenTree Warning) +Warnings - These are non-critical errors which should be addressed when possible. + +### INVE-I (InvenTree Information) +Information — These are not errors but information messages. They might point out potential issues or just provide information. + +### INVE-M (InvenTree Miscellaneous) +Miscellaneous — These are information messages that might be used to mark debug information or other messages helpful for the InvenTree team to understand behaviour. diff --git a/docs/mkdocs.yml b/docs/mkdocs.yml index 314d2f2449..7bfc8ac05e 100644 --- a/docs/mkdocs.yml +++ b/docs/mkdocs.yml @@ -152,15 +152,18 @@ nav: - User Settings: settings/user.md - Reference Patterns: settings/reference.md - Admin Interface: settings/admin.md - - User Permissions: settings/permissions.md - - Single Sign on: settings/SSO.md - - Multi Factor Authentication: settings/MFA.md + - Setup: + - User Permissions: settings/permissions.md + - Single Sign on: settings/SSO.md + - Multi Factor Authentication: settings/MFA.md + - Email: settings/email.md + - Currency Support: settings/currency.md - Export Data: settings/export.md - Import Data: settings/import.md - - Error Logs: settings/logs.md - - Email: settings/email.md - - Background Tasks: settings/tasks.md - - Currency Support: settings/currency.md + - Operations: + - Background Tasks: settings/tasks.md + - Error Logs: settings/logs.md + - Error Codes: settings/error_codes.md - App: - InvenTree App: app/app.md - Connect: app/connect.md diff --git a/src/backend/InvenTree/web/templates/web/index.html b/src/backend/InvenTree/web/templates/web/index.html index 7d4d33c4a4..300368d9b4 100644 --- a/src/backend/InvenTree/web/templates/web/index.html +++ b/src/backend/InvenTree/web/templates/web/index.html @@ -1,5 +1,6 @@ {% load spa_helper %} {% load inventree_extras %} +{% spa_bundle as bundle %} @@ -12,8 +13,17 @@
- {% spa_settings %} - {% spa_bundle %} +
{% spa_settings %}
+ {% if bundle == "NOT_FOUND" %} +
+
+

INVE-E1 - No frontend included

+

The frontend bundle could not be found. Please check that your deployment method includes the bundle or check the FAQ.
+ Install method: {% inventree_installer %}

+
+ {% else %} +
{{ bundle }}
+ {% endif %} diff --git a/src/backend/InvenTree/web/templatetags/spa_helper.py b/src/backend/InvenTree/web/templatetags/spa_helper.py index 11bfc734fb..743d1ef17b 100644 --- a/src/backend/InvenTree/web/templatetags/spa_helper.py +++ b/src/backend/InvenTree/web/templatetags/spa_helper.py @@ -38,13 +38,13 @@ def spa_bundle(manifest_path: Union[str, Path] = '', app: str = 'web'): # Final check - fail if manifest file not found if not manifest.exists(): logger.error('Manifest file not found') - return + return 'NOT_FOUND' try: manifest_data = json.load(manifest.open()) except (TypeError, json.decoder.JSONDecodeError): logger.exception('Failed to parse manifest file') - return + return '' return_string = '' # JS (based on index.html file as entrypoint) diff --git a/src/backend/InvenTree/web/tests.py b/src/backend/InvenTree/web/tests.py index 72d5f5d402..d37c7c0af9 100644 --- a/src/backend/InvenTree/web/tests.py +++ b/src/backend/InvenTree/web/tests.py @@ -24,9 +24,8 @@ class TemplateTagTest(InvenTreeTestCase): def test_spa_bundle(self): """Test the 'spa_bundle' template tag.""" resp = spa_helper.spa_bundle() - if not resp: + if resp == 'NOT_FOUND': # No Vite, no test - # TODO: Add a test for the non-Vite case (docker) return # pragma: no cover shipped_js = resp.split('