inventree/InvenTree
2
0
Fork 0
mirror of https://github.com/inventree/InvenTree.git synced 2025-04-29 12:06:44 +00:00
Code

Barcode validation fix (#9127)

Browse Source 
* Fix logic for adding items to SalesOrder

* Same thing for purchase orders

* Update serializers.py

Revert typo fix

- Otherwise, we need to do an API bump and the PR can't be back-ported!
This commit is contained in:
Oliver 2025-02-21 22:17:55 +11:00 committed by GitHub
parent 6930ae7122
commit bc9dbf7df4
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 9 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/backend/InvenTree/plugin/base/barcodes/serializers.py
View File

@ -11,7 +11,11 @@ import order.models
import plugin.base.barcodes.helper import plugin.base.barcodes.helper
import stock.models import stock.models
from InvenTree.serializers import UserSerializer from InvenTree.serializers import UserSerializer
from order.status_codes import PurchaseOrderStatus, SalesOrderStatus from order.status_codes import (
PurchaseOrderStatus,
PurchaseOrderStatusGroups,
SalesOrderStatusGroups,
)
class BarcodeScanResultSerializer(serializers.ModelSerializer): class BarcodeScanResultSerializer(serializers.ModelSerializer):
@ -135,8 +139,8 @@ class BarcodePOAllocateSerializer(BarcodeSerializer):
def validate_purchase_order(self, order: order.models.PurchaseOrder): def validate_purchase_order(self, order: order.models.PurchaseOrder):
"""Validate the provided order.""" """Validate the provided order."""
if order.status != PurchaseOrderStatus.PENDING.value: if order.status not in PurchaseOrderStatusGroups.OPEN:
raise ValidationError(_('Purchase order is not pending')) raise ValidationError(_('Purchase order is not open'))
return order return order
@ -213,8 +217,8 @@ class BarcodeSOAllocateSerializer(BarcodeSerializer):
def validate_sales_order(self, order: order.models.SalesOrder): def validate_sales_order(self, order: order.models.SalesOrder):
"""Validate the provided order.""" """Validate the provided order."""
if order and order.status != SalesOrderStatus.PENDING.value: if order and order.status not in SalesOrderStatusGroups.OPEN:
raise ValidationError(_('Sales order is not pending')) raise ValidationError(_('Sales order is not open'))
return order return order