From c8b1bfb71652857c5fe36db26b5ef944e1111b00 Mon Sep 17 00:00:00 2001
From: Matthias Mair <code@mjmair.com>
Date: Tue, 2 Dec 2025 07:11:02 +0000
Subject: [PATCH] refactor (frontend): address code scanning issues (#10935)

* remove unused defs

* optimize

* revert rename
---
 src/frontend/src/components/buttons/PrintingActions.tsx   | 4 ++--
 src/frontend/src/hooks/UseDataExport.tsx                  | 2 +-
 src/frontend/src/hooks/UseDataOutput.tsx                  | 2 +-
 src/frontend/src/hooks/UseImportSession.tsx               | 2 +-
 src/frontend/src/pages/sales/SalesOrderShipmentDetail.tsx | 6 +-----
 src/frontend/src/tables/machine/MachineTypeTable.tsx      | 4 +---
 6 files changed, 7 insertions(+), 13 deletions(-)

diff --git a/src/frontend/src/components/buttons/PrintingActions.tsx b/src/frontend/src/components/buttons/PrintingActions.tsx
index dad818e96f..4dbb997af9 100644
--- a/src/frontend/src/components/buttons/PrintingActions.tsx
+++ b/src/frontend/src/components/buttons/PrintingActions.tsx
@@ -52,12 +52,12 @@ export function PrintingActions({
   const [labelId, setLabelId] = useState<number | undefined>(undefined);
   const [reportId, setReportId] = useState<number | undefined>(undefined);
 
-  const labelProgress = useDataOutput({
+  useDataOutput({
     title: t`Printing Labels`,
     id: labelId
   });
 
-  const reportProgress = useDataOutput({
+  useDataOutput({
     title: t`Printing Reports`,
     id: reportId
   });
diff --git a/src/frontend/src/hooks/UseDataExport.tsx b/src/frontend/src/hooks/UseDataExport.tsx
index 653a79beb3..8237f326e8 100644
--- a/src/frontend/src/hooks/UseDataExport.tsx
+++ b/src/frontend/src/hooks/UseDataExport.tsx
@@ -30,7 +30,7 @@ export default function useDataExport({
 
   const [exportId, setExportId] = useState<number | undefined>(undefined);
 
-  const progress = useDataOutput({
+  useDataOutput({
     title: t`Exporting Data`,
     id: exportId
   });
diff --git a/src/frontend/src/hooks/UseDataOutput.tsx b/src/frontend/src/hooks/UseDataOutput.tsx
index 7844e899c0..84be903f70 100644
--- a/src/frontend/src/hooks/UseDataOutput.tsx
+++ b/src/frontend/src/hooks/UseDataOutput.tsx
@@ -40,7 +40,7 @@ export default function useDataOutput({
     } else setLoading(false);
   }, [id, title]);
 
-  const progress = useQuery({
+  useQuery({
     enabled: !!id && loading && visibility === 'visible',
     refetchInterval: 500,
     queryKey: ['data-output', id, title],
diff --git a/src/frontend/src/hooks/UseImportSession.tsx b/src/frontend/src/hooks/UseImportSession.tsx
index 7503228c03..5410e77ee7 100644
--- a/src/frontend/src/hooks/UseImportSession.tsx
+++ b/src/frontend/src/hooks/UseImportSession.tsx
@@ -49,7 +49,7 @@ export function useImportSession({
     setInstance(data);
   }, []);
 
-  const importSessionStatus = useStatusCodes({
+  useStatusCodes({
     modelType: ModelType.importsession
   });
 
diff --git a/src/frontend/src/pages/sales/SalesOrderShipmentDetail.tsx b/src/frontend/src/pages/sales/SalesOrderShipmentDetail.tsx
index 153933dac9..2a0954ea42 100644
--- a/src/frontend/src/pages/sales/SalesOrderShipmentDetail.tsx
+++ b/src/frontend/src/pages/sales/SalesOrderShipmentDetail.tsx
@@ -72,11 +72,7 @@ export default function SalesOrderShipmentDetail() {
     }
   });
 
-  const {
-    instance: customer,
-    instanceQuery: customerQuery,
-    refreshInstance: refreshCustomer
-  } = useInstance({
+  const { instance: customer, instanceQuery: customerQuery } = useInstance({
     endpoint: ApiEndpoints.company_list,
     pk: shipment.order_detail?.customer,
     hasPrimaryKey: true
diff --git a/src/frontend/src/tables/machine/MachineTypeTable.tsx b/src/frontend/src/tables/machine/MachineTypeTable.tsx
index f7496da4d7..c9aebc29e8 100644
--- a/src/frontend/src/tables/machine/MachineTypeTable.tsx
+++ b/src/frontend/src/tables/machine/MachineTypeTable.tsx
@@ -103,9 +103,7 @@ export function MachineDriverTable({
 function MachineTypeDrawer({
   machineTypeSlug
 }: Readonly<{ machineTypeSlug: string }>) {
-  const navigate = useNavigate();
-
-  const { machineTypes, refresh, isFetching } = useMachineTypeDriver({
+  const { machineTypes, isFetching } = useMachineTypeDriver({
     includeDrivers: false
   });
   const machineType = useMemo(