From d0f9d0d830b993d5d4b775818b7ff18fc5d84022 Mon Sep 17 00:00:00 2001 From: Oliver Date: Fri, 31 Mar 2023 10:59:28 +1100 Subject: [PATCH] Change SalesOrder.can_cancel() (#4544) * Change SalesOrder.can_cancel() * fix --- InvenTree/order/models.py | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/InvenTree/order/models.py b/InvenTree/order/models.py index 18bb37aa8e..c36487a7dd 100644 --- a/InvenTree/order/models.py +++ b/InvenTree/order/models.py @@ -868,14 +868,11 @@ class SalesOrder(TotalPriceMixin, Order): def can_cancel(self): """Return True if this order can be cancelled.""" - if self.status != SalesOrderStatus.PENDING: - return False - - return True + return self.is_open @transaction.atomic def cancel_order(self): - """Cancel this order (only if it is "pending"). + """Cancel this order (only if it is "open"). Executes: - Mark the order as 'cancelled'