From d5d0bfabc42478dfad1416d3f2e23bfe3d0b6a8f Mon Sep 17 00:00:00 2001 From: Matthias Mair Date: Wed, 4 Nov 2026 23:35:27 +0100 Subject: [PATCH] Small fixes (#13190) * remove iregular import pattern * remove dead code * remove unneeded import --- src/backend/InvenTree/InvenTree/validators.py | 16 ---------------- src/backend/InvenTree/stock/models.py | 9 ++------- src/backend/InvenTree/users/api.py | 3 +-- 3 files changed, 3 insertions(+), 25 deletions(-) diff --git a/src/backend/InvenTree/InvenTree/validators.py b/src/backend/InvenTree/InvenTree/validators.py index 13ab702e07..973b289f04 100644 --- a/src/backend/InvenTree/InvenTree/validators.py +++ b/src/backend/InvenTree/InvenTree/validators.py @@ -123,21 +123,5 @@ def invalid_site_url_hint(site_url: str) -> str: return '' -def validate_purchase_order_reference(value): - """Validate the 'reference' field of a PurchaseOrder.""" - from order.models import PurchaseOrder - - # If we get to here, run the "default" validation routine - PurchaseOrder.validate_reference_field(value) - - -def validate_sales_order_reference(value): - """Validate the 'reference' field of a SalesOrder.""" - from order.models import SalesOrder - - # If we get to here, run the "default" validation routine - SalesOrder.validate_reference_field(value) - - def validate_tree_name(value): """Placeholder for legacy function used in migrations.""" diff --git a/src/backend/InvenTree/stock/models.py b/src/backend/InvenTree/stock/models.py index 5ba0db69d1..cc4172ca8e 100644 --- a/src/backend/InvenTree/stock/models.py +++ b/src/backend/InvenTree/stock/models.py @@ -45,17 +45,12 @@ from generic.states import StatusCodeMixin from generic.states.fields import InvenTreeCustomStatusModelField from InvenTree.fields import InvenTreeModelMoneyField, InvenTreeURLField from InvenTree.helpers_db import bulk_create_and_fetch -from InvenTree.status_codes import ( - SalesOrderStatusGroups, - StockHistoryCode, - StockStatus, - StockStatusGroups, -) -from order.status_codes import TransferOrderStatusGroups +from order.status_codes import SalesOrderStatusGroups, TransferOrderStatusGroups from part import models as PartModels from plugin.events import trigger_event from stock.events import StockEvents from stock.generators import generate_batch_code +from stock.status_codes import StockHistoryCode, StockStatus, StockStatusGroups from users.models import Owner logger = structlog.get_logger('inventree') diff --git a/src/backend/InvenTree/users/api.py b/src/backend/InvenTree/users/api.py index 2d8977021d..53b2105dcf 100644 --- a/src/backend/InvenTree/users/api.py +++ b/src/backend/InvenTree/users/api.py @@ -39,7 +39,6 @@ from InvenTree.mixins import ( UpdateAPI, ) from InvenTree.schema import exclude_from_schema -from InvenTree.settings import FRONTEND_URL_BASE from users.models import ( ApiToken, Owner, @@ -584,7 +583,7 @@ class LoginRedirect(RedirectView): def get_redirect_url(self, *args, **kwargs): """Return the URL to redirect to.""" - return f'/{FRONTEND_URL_BASE}/logged-in/' + return InvenTree.helpers.pui_url('logged-in/') class UserProfileDetail(RetrieveUpdateAPI):