From da21e39e849fde93cc2c8aa9119dbf8a8583c41d Mon Sep 17 00:00:00 2001 From: Matthias Mair Date: Thu, 26 Dec 2024 10:16:53 +0100 Subject: [PATCH] Turn off debug by default (#8743) * turn off debug by default * fix log level / debug settings for workflows * fix typo --- .github/workflows/check_translations.yaml | 3 ++- .github/workflows/qc_checks.yaml | 16 +++++++++++----- .github/workflows/translations.yaml | 3 ++- src/backend/InvenTree/InvenTree/settings.py | 2 +- src/backend/InvenTree/config_template.yaml | 2 +- 5 files changed, 17 insertions(+), 9 deletions(-) diff --git a/.github/workflows/check_translations.yaml b/.github/workflows/check_translations.yaml index c8628e1010..ec07c26f64 100644 --- a/.github/workflows/check_translations.yaml +++ b/.github/workflows/check_translations.yaml @@ -22,7 +22,8 @@ jobs: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} INVENTREE_DB_NAME: "./test_db.sqlite" INVENTREE_DB_ENGINE: django.db.backends.sqlite3 - INVENTREE_DEBUG: info + INVENTREE_DEBUG: true + INVENTREE_LOG_LEVEL: INFO INVENTREE_MEDIA_ROOT: ./media INVENTREE_STATIC_ROOT: ./static INVENTREE_BACKUP_DIR: ./backup diff --git a/.github/workflows/qc_checks.yaml b/.github/workflows/qc_checks.yaml index 7b685369a3..a0c737f551 100644 --- a/.github/workflows/qc_checks.yaml +++ b/.github/workflows/qc_checks.yaml @@ -242,6 +242,8 @@ jobs: INVENTREE_PYTHON_TEST_USERNAME: testuser INVENTREE_PYTHON_TEST_PASSWORD: testpassword INVENTREE_SITE_URL: http://127.0.0.1:12345 + INVENTREE_DEBUG: true + INVENTREE_LOG_LEVEL: INFO steps: - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # pin@v4.2.2 @@ -324,7 +326,8 @@ jobs: INVENTREE_DB_PASSWORD: password INVENTREE_DB_HOST: "127.0.0.1" INVENTREE_DB_PORT: 5432 - INVENTREE_DEBUG: info + INVENTREE_DEBUG: true + INVENTREE_LOG_LEVEL: INFO INVENTREE_CACHE_HOST: localhost INVENTREE_PLUGINS_ENABLED: true @@ -372,7 +375,8 @@ jobs: INVENTREE_DB_PASSWORD: password INVENTREE_DB_HOST: "127.0.0.1" INVENTREE_DB_PORT: 3306 - INVENTREE_DEBUG: info + INVENTREE_DEBUG: true + INVENTREE_LOG_LEVEL: INFO INVENTREE_PLUGINS_ENABLED: true services: @@ -417,7 +421,8 @@ jobs: INVENTREE_DB_PASSWORD: password INVENTREE_DB_HOST: "127.0.0.1" INVENTREE_DB_PORT: 5432 - INVENTREE_DEBUG: info + INVENTREE_DEBUG: true + INVENTREE_LOG_LEVEL: INFO INVENTREE_PLUGINS_ENABLED: false services: @@ -459,7 +464,8 @@ jobs: env: INVENTREE_DB_ENGINE: sqlite3 INVENTREE_DB_NAME: /home/runner/work/InvenTree/db.sqlite3 - INVENTREE_DEBUG: info + INVENTREE_DEBUG: true + INVENTREE_LOG_LEVEL: INFO INVENTREE_PLUGINS_ENABLED: false steps: @@ -517,7 +523,7 @@ jobs: env: INVENTREE_DB_ENGINE: sqlite3 INVENTREE_DB_NAME: /home/runner/work/InvenTree/db.sqlite3 - INVENTREE_DEBUG: True + INVENTREE_DEBUG: true INVENTREE_PLUGINS_ENABLED: false VITE_COVERAGE: true diff --git a/.github/workflows/translations.yaml b/.github/workflows/translations.yaml index 82fd505457..dc769e7f28 100644 --- a/.github/workflows/translations.yaml +++ b/.github/workflows/translations.yaml @@ -23,7 +23,8 @@ jobs: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} INVENTREE_DB_NAME: "./test_db.sqlite" INVENTREE_DB_ENGINE: django.db.backends.sqlite3 - INVENTREE_DEBUG: info + INVENTREE_DEBUG: true + INVENTREE_LOG_LEVEL: INFO INVENTREE_MEDIA_ROOT: ./media INVENTREE_STATIC_ROOT: ./static INVENTREE_BACKUP_DIR: ./backup diff --git a/src/backend/InvenTree/InvenTree/settings.py b/src/backend/InvenTree/InvenTree/settings.py index 301f11fac4..e86f087a42 100644 --- a/src/backend/InvenTree/InvenTree/settings.py +++ b/src/backend/InvenTree/InvenTree/settings.py @@ -77,7 +77,7 @@ if version_file.exists(): # Default action is to run the system in Debug mode # SECURITY WARNING: don't run with debug turned on in production! -DEBUG = get_boolean_setting('INVENTREE_DEBUG', 'debug', True) +DEBUG = get_boolean_setting('INVENTREE_DEBUG', 'debug', False) # Configure logging settings LOG_LEVEL = get_setting('INVENTREE_LOG_LEVEL', 'log_level', 'WARNING') diff --git a/src/backend/InvenTree/config_template.yaml b/src/backend/InvenTree/config_template.yaml index 99213ce9c3..65c13d569c 100644 --- a/src/backend/InvenTree/config_template.yaml +++ b/src/backend/InvenTree/config_template.yaml @@ -26,7 +26,7 @@ database: # PORT: Database host port (if required) # Set debug to False to run in production mode, or use the environment variable INVENTREE_DEBUG -debug: True +debug: False # Additional debug options debug_querycount: False