inventree/InvenTree
2
0
Fork 0
mirror of https://github.com/inventree/InvenTree.git synced 2025-07-16 17:56:30 +00:00
Code Activity

refactor: refactor unnecessary else / elif when if block has a return statement (#5735)

Browse Source 
The use of `else` or `elif` becomes redundant and can be dropped if the last statement under the leading `if` / `elif` block is a `return` statement.
In the case of an `elif` after `return`, it can be written as a separate `if` block.
For `else` blocks after `return`, the statements can be shifted out of `else`. Please refer to the examples below for reference.

Refactoring the code this way can improve code-readability and make it easier to maintain.

Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>
This commit is contained in:
Matthias Mair
2023-10-18 00:06:54 +02:00
committed by GitHub
parent 3f93151cca
commit eb79bd1743
29 changed files with 123 additions and 235 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
InvenTree/label/api.py
View File

@@ -171,8 +171,7 @@ class LabelPrintMixin(LabelFilterMixin):
if plugin.is_active():
# Only return the plugin if it is enabled!
return plugin
else:
raise ValidationError(f"Plugin '{plugin_key}' is not enabled")
raise ValidationError(f"Plugin '{plugin_key}' is not enabled")
else:
raise NotFound(f"Plugin '{plugin_key}' not found")
@@ -196,8 +195,7 @@ class LabelPrintMixin(LabelFilterMixin):
if isinstance(result, JsonResponse):
result['plugin'] = plugin.plugin_slug()
return result
else:
raise ValidationError(f"Plugin '{plugin.plugin_slug()}' returned invalid response type '{type(result)}'")
raise ValidationError(f"Plugin '{plugin.plugin_slug()}' returned invalid response type '{type(result)}'")
class StockItemLabelMixin: