Add more checks to pre-commit (#3132)

* Add bandit to pre-commit checks

* fix catchall exceptions

* remove unused definitons

* remove unuseed ariables

* Add docstring

* fix B006, B008 errors

* fix B007 error

* ignore B009

* Add checks for formatting and naming

InvenTree/common/apps.py

@@ -27,5 +27,5 @@ class CommonConfig(AppConfig):
             if common.models.InvenTreeSetting.get_setting('SERVER_RESTART_REQUIRED', backup_value=False, create=False):
                 logger.info("Clearing SERVER_RESTART_REQUIRED flag")
                 common.models.InvenTreeSetting.set_setting('SERVER_RESTART_REQUIRED', False, None)
-        except:
+        except Exception:
             pass

InvenTree/common/files.py

@@ -142,7 +142,7 @@ class FileManager:
             guess = self.guess_header(header, threshold=95)
             # Check if already present
             guess_exists = False
-            for idx, data in enumerate(headers):
+            for _idx, data in enumerate(headers):
                 if guess == data['guess']:
                     guess_exists = True
                     break

InvenTree/common/models.py

@@ -571,7 +571,7 @@ class BaseInvenTreeSetting(models.Model):
             # If a valid class has been found, see if it has registered an API URL
             try:
                 return model_class.get_api_url()
-            except:
+            except Exception:
                 pass
 
         return None

InvenTree/common/views.py

@@ -495,8 +495,12 @@ class FileManagementAjaxView(AjaxView):
             self.storage.current_step = self.steps.first
         return self.renderJsonResponse(request)
 
-    def renderJsonResponse(self, request, form=None, data={}, context=None):
+    def renderJsonResponse(self, request, form=None, data=None, context=None):
         """Always set the right templates before rendering."""
+        # Set default - see B006
+        if data is None:
+            data = {}
+
         self.setTemplate()
         return super().renderJsonResponse(request, form=form, data=data, context=context)