Add more checks to pre-commit (#3132)

* Add bandit to pre-commit checks

* fix catchall exceptions

* remove unused definitons

* remove unuseed ariables

* Add docstring

* fix B006, B008 errors

* fix B007 error

* ignore B009

* Add checks for formatting and naming

InvenTree/label/api.py

@@ -363,7 +363,7 @@ class StockLocationLabelList(LabelListView, StockLocationLabelMixin):
                 # Filter string defined for the StockLocationLabel object
                 try:
                     filters = InvenTree.helpers.validateFilterString(label.filters)
-                except:  # pragma: no cover
+                except Exception:  # pragma: no cover
                     # Skip if there was an error validating the filters...
                     continue
 

InvenTree/label/test_api.py

@@ -22,8 +22,12 @@ class TestReportTests(InvenTreeAPITestCase):
 
     list_url = reverse('api-stockitem-testreport-list')
 
-    def do_list(self, filters={}):
+    def do_list(self, filters=None):
         """Helper function to request list of labels with provided filters"""
+        # Set default - see B006
+        if filters is None:
+            filters = {}
+
         response = self.client.get(self.list_url, filters, format='json')
 
         self.assertEqual(response.status_code, 200)