Add more checks to pre-commit (#3132)

* Add bandit to pre-commit checks

* fix catchall exceptions

* remove unused definitons

* remove unuseed ariables

* Add docstring

* fix B006, B008 errors

* fix B007 error

* ignore B009

* Add checks for formatting and naming

InvenTree/part/api.py

@@ -606,7 +606,7 @@ class PartCopyBOM(generics.CreateAPIView):
 
         try:
             ctx['part'] = Part.objects.get(pk=self.kwargs.get('pk', None))
-        except:
+        except Exception:
             pass
 
         return ctx
@@ -1042,12 +1042,12 @@ class PartList(APIDownloadMixin, generics.ListCreateAPIView):
 
             try:
                 manufacturer = Company.objects.get(pk=request.data.get('manufacturer', None))
-            except:
+            except Exception:
                 manufacturer = None
 
             try:
                 supplier = Company.objects.get(pk=request.data.get('supplier', None))
-            except:
+            except Exception:
                 supplier = None
 
             mpn = str(request.data.get('MPN', '')).strip()

InvenTree/part/models.py

@@ -593,7 +593,7 @@ class Part(MetadataMixin, MPTTModel):
         try:
             latest = int(latest)
             return latest
-        except:
+        except Exception:
             # not an integer so 0
             return 0
 
@@ -610,7 +610,7 @@ class Part(MetadataMixin, MPTTModel):
         # Attempt to turn into an integer
         try:
             latest = int(latest)
-        except:
+        except Exception:
             pass
 
         if type(latest) is int:
@@ -2283,7 +2283,7 @@ class PartTestTemplate(models.Model):
 
 def validate_template_name(name):
     """Prevent illegal characters in "name" field for PartParameterTemplate."""
-    for c in "!@#$%^&*()<>{}[].,?/\\|~`_+-=\'\"":
+    for c in "!@#$%^&*()<>{}[].,?/\\|~`_+-=\'\"":  # noqa: P103
         if c in str(name):
             raise ValidationError(_(f"Illegal character in template name ({c})"))
 

InvenTree/part/serializers.py

@@ -902,7 +902,7 @@ class BomImportExtractSerializer(DataFileExtractSerializer):
                 if level != 1:
                     # Skip this row
                     return None
-            except:
+            except Exception:
                 pass
 
         # Attempt to extract a valid part based on the provided data
@@ -954,7 +954,7 @@ class BomImportExtractSerializer(DataFileExtractSerializer):
 
                 if quantity <= 0:
                     row['errors']['quantity'] = _('Quantity must be greater than zero')
-            except:
+            except Exception:
                 row['errors']['quantity'] = _('Invalid quantity')
 
         return row

InvenTree/part/templatetags/inventree_extras.py

@@ -412,7 +412,7 @@ def primitive_to_javascript(primitive):
 
     else:
         # Wrap with quotes
-        return format_html("'{}'", primitive)
+        return format_html("'{}'", primitive)  # noqa: P103
 
 
 @register.filter
@@ -458,7 +458,7 @@ def authorized_owners(group):
 def object_link(url_name, pk, ref):
     """Return highlighted link to object."""
     ref_url = reverse(url_name, kwargs={'pk': pk})
-    return mark_safe('<b><a href="{}">{}</a></b>'.format(ref_url, ref))
+    return mark_safe(f'<b><a href="{ref_url}">{ref}</a></b>')
 
 
 @register.simple_tag()

InvenTree/part/test_api.py

@@ -1285,7 +1285,7 @@ class PartAPIAggregationTest(InvenTreeAPITestCase):
         self.assertEqual(data['stock_item_count'], 4)
 
         # Add some more stock items!!
-        for i in range(100):
+        for _ in range(100):
             StockItem.objects.create(part=self.part, quantity=5)
 
         # Add another stock item which is assigned to a customer (and shouldn't count)
@@ -1628,7 +1628,7 @@ class BomItemTest(InvenTreeAPITestCase):
             Part.objects.rebuild()
 
             # Create some stock items for this new part
-            for jj in range(ii):
+            for _ in range(ii):
                 StockItem.objects.create(
                     part=variant,
                     location=loc,

InvenTree/part/test_bom_import.py

@@ -228,7 +228,7 @@ class BomUploadTest(InvenTreeAPITestCase):
 
         components = Part.objects.filter(component=True)
 
-        for idx, cmp in enumerate(components):
+        for idx, _ in enumerate(components):
             dataset.append([
                 f"Component {idx}",
                 10,
@@ -257,7 +257,7 @@ class BomUploadTest(InvenTreeAPITestCase):
 
         dataset.headers = ['part_ipn', 'quantity']
 
-        for idx, cmp in enumerate(components):
+        for idx, _ in enumerate(components):
             dataset.append([
                 f"CMP_{idx}",
                 10,

InvenTree/part/test_part.py

@@ -190,7 +190,7 @@ class PartTest(TestCase):
         try:
             part.save()
             self.assertTrue(False)  # pragma: no cover
-        except:
+        except Exception:
             pass
 
         self.assertEqual(Part.objects.count(), n + 1)

InvenTree/part/views.py

@@ -618,7 +618,7 @@ class PartImageDownloadFromURL(AjaxUpdateView):
         try:
             self.image = Image.open(response.raw).convert()
             self.image.verify()
-        except:
+        except Exception:
             form.add_error('url', _("Supplied URL is not a valid image file"))
             return