From fb280d80e718e74ddaf3d62567c71293f5ceae9d Mon Sep 17 00:00:00 2001 From: Oliver Date: Tue, 30 Jun 2026 18:54:35 +1000 Subject: [PATCH] Fix for STOCK_COUNT event (#12281) * Fix for STOCK_COUNT event - Prevent double emission of event type string * adjust unit test --- src/backend/InvenTree/stock/models.py | 7 ++----- src/backend/InvenTree/stock/tests.py | 6 ++---- 2 files changed, 4 insertions(+), 9 deletions(-) diff --git a/src/backend/InvenTree/stock/models.py b/src/backend/InvenTree/stock/models.py index 39a476d9c8..fe7286674f 100644 --- a/src/backend/InvenTree/stock/models.py +++ b/src/backend/InvenTree/stock/models.py @@ -2663,7 +2663,7 @@ class StockItem( return True @transaction.atomic - def stocktake(self, count, user, **kwargs): + def stocktake(self, count, user, **kwargs) -> None: """Perform item stocktake. Arguments: @@ -2678,7 +2678,7 @@ class StockItem( try: count = Decimal(count) except InvalidOperation: - return False + return if count < 0: return False @@ -2729,13 +2729,10 @@ class StockItem( trigger_event( StockEvents.ITEM_COUNTED, - 'stockitem.counted', id=self.id, quantity=1 if self.serialized else float(self.quantity), ) - return True - @transaction.atomic def add_stock(self, quantity, user, **kwargs): """Add a specified quantity of stock to this item. diff --git a/src/backend/InvenTree/stock/tests.py b/src/backend/InvenTree/stock/tests.py index 999fc030b0..c0715bda64 100644 --- a/src/backend/InvenTree/stock/tests.py +++ b/src/backend/InvenTree/stock/tests.py @@ -378,10 +378,8 @@ class StockTest(StockTestBase): self.assertEqual(it.status, StockStatus.OK.value) # Next, perform a valid stocktake - self.assertTrue( - it.stocktake( - 100, None, notes='test stocktake', status=StockStatus.DAMAGED.value - ) + it.stocktake( + 100, None, notes='test stocktake', status=StockStatus.DAMAGED.value ) it.refresh_from_db()