mirror of
https://github.com/inventree/InvenTree.git
synced 2026-04-17 16:58:42 +00:00
* Lazy evaluation of optional serializer fields - Add OptionalField dataclass - Pass serializer class and kwargs separately * Refactor BuildLineSerializer class * Simplify gathering * Refactor BuildSerializer * Refactor other Build serializers * Refactor Part serializers * Refactoring more serializers to use OptionalField * More refactoring * Cleanup for mixin class * Ensure any optional fields we added in are not missed * Fixes * Rehydrate optional fields for metadata * Add TreePathSerializer class * Further improvements: - Handle case where optional field shadows model property - Consider read_only and write_only fields * Adjust unit tests * Fix for "build_relational_field" - Handle case where optional field shadows model relation * Fix case where multiple fields can share same filter * additional unit tests * Bump API version * Remove top-level detection - Request object is only available for the top-level serializer anyway * Cache serializer to prevent multiple __init__ calls * Revert caching change - Breaks search results * Simplify field removal * Adjust unit test * Remove docstring comment which is no longer true * Ensure read-only fields are skipped for data import * Use SAFE_METHODS * Do not convert to lowercase * Updated docstring * Remove FilterableSerializerField mixin - Annotation now performed using OptionalField - Code can be greatly simplified * Ensure all fields are returned when generating schema * Fix order of operations * Add assertion to unit test * fix style * Fix api_version * Remove duplicate API entries * Remove duplicate API entries * Fix formatting in api_version.py * Tweak ManufacturerPart serializer * Revert formatting change --------- Co-authored-by: Matthias Mair <code@mjmair.com>
546 lines
18 KiB
Python
546 lines
18 KiB
Python
"""API tests for various user / auth API endpoints."""
|
|
|
|
import datetime
|
|
|
|
from django.contrib.auth.models import Group, User
|
|
from django.urls import reverse
|
|
|
|
from InvenTree.unit_test import InvenTreeAPITestCase
|
|
from users.models import ApiToken
|
|
from users.ruleset import RULESET_NAMES, get_ruleset_models
|
|
|
|
|
|
class UserAPITests(InvenTreeAPITestCase):
|
|
"""Tests for user API endpoints."""
|
|
|
|
def test_user_options(self):
|
|
"""Tests for the User OPTIONS request."""
|
|
self.assignRole('admin.add')
|
|
response = self.options(reverse('api-user-list'), expected_code=200)
|
|
|
|
self.user.is_staff = True
|
|
self.user.save()
|
|
|
|
# User is a *staff* user with *admin* role, so can POST against this endpoint
|
|
self.assertIn('POST', response.data['actions'])
|
|
|
|
fields = response.data['actions']['GET']
|
|
|
|
# Check some of the field values
|
|
self.assertEqual(fields['username']['label'], 'Username')
|
|
|
|
self.assertEqual(fields['email']['label'], 'Email')
|
|
self.assertEqual(fields['email']['help_text'], 'Email address of the user')
|
|
|
|
self.assertEqual(fields['is_active']['label'], 'Active')
|
|
self.assertEqual(
|
|
fields['is_active']['help_text'], 'Is this user account active'
|
|
)
|
|
|
|
self.assertEqual(fields['is_staff']['label'], 'Administrator')
|
|
self.assertEqual(
|
|
fields['is_staff']['help_text'],
|
|
'Does this user have administrative permissions',
|
|
)
|
|
|
|
def test_api_url(self):
|
|
"""Test the 'api_url' attribute in related API endpoints.
|
|
|
|
Ref: https://github.com/inventree/InvenTree/pull/10182
|
|
"""
|
|
self.user.is_superuser = True
|
|
self.user.save()
|
|
|
|
url = reverse('api-build-list')
|
|
response = self.options(url)
|
|
actions = response.data['actions']['POST']
|
|
issued_by = actions['issued_by']
|
|
|
|
self.assertEqual(issued_by['pk_field'], 'pk')
|
|
self.assertEqual(issued_by['model'], 'user')
|
|
self.assertEqual(issued_by['api_url'], reverse('api-user-list'))
|
|
self.assertEqual(issued_by['default'], self.user.pk)
|
|
|
|
def test_user_api(self):
|
|
"""Tests for User API endpoints."""
|
|
url = reverse('api-user-list')
|
|
response = self.get(url, expected_code=200)
|
|
|
|
# Check the correct number of results was returned
|
|
self.assertEqual(len(response.data), User.objects.count())
|
|
|
|
for key in ['username', 'pk', 'email']:
|
|
self.assertIn(key, response.data[0])
|
|
|
|
# Check detail URL
|
|
pk = response.data[0]['pk']
|
|
|
|
response = self.get(
|
|
reverse('api-user-detail', kwargs={'pk': pk}), expected_code=200
|
|
)
|
|
|
|
self.assertIn('pk', response.data)
|
|
self.assertIn('username', response.data)
|
|
|
|
data = {
|
|
'username': 'test',
|
|
'first_name': 'Test',
|
|
'last_name': 'User',
|
|
'email': 'aa@example.org',
|
|
}
|
|
|
|
# Test create user - requires staff access with 'admin' role
|
|
response = self.post(url, data=data, expected_code=403)
|
|
self.assertIn(
|
|
'You do not have permission to perform this action.', str(response.data)
|
|
)
|
|
|
|
# Try again with "staff" access
|
|
self.user.is_staff = True
|
|
self.user.save()
|
|
|
|
# Try again - should fail still, as user does not have "admin" role
|
|
response = self.post(url, data=data, expected_code=403)
|
|
|
|
# Assign the "admin" role to the user
|
|
self.assignRole('admin.view')
|
|
|
|
# Fail again - user does not have "add" permission against the "admin" role
|
|
response = self.post(url, data=data, expected_code=403)
|
|
|
|
self.assignRole('admin.add')
|
|
|
|
response = self.post(url, data=data, expected_code=201)
|
|
|
|
self.assertEqual(response.data['username'], 'test')
|
|
self.assertEqual(response.data['first_name'], 'Test')
|
|
self.assertEqual(response.data['last_name'], 'User')
|
|
self.assertEqual(response.data['is_staff'], False)
|
|
self.assertEqual(response.data['is_superuser'], False)
|
|
self.assertEqual(response.data['is_active'], True)
|
|
|
|
# Try to adjust the 'is_superuser' field
|
|
# Only a "superuser" can set this field
|
|
response = self.post(
|
|
url,
|
|
data={**data, 'username': 'Superuser', 'is_superuser': True},
|
|
expected_code=403,
|
|
)
|
|
|
|
self.assertIn('Only a superuser can adjust this field', str(response.data))
|
|
|
|
# Try again, but with superuser access
|
|
self.user.is_superuser = True
|
|
self.user.save()
|
|
|
|
response = self.post(
|
|
url,
|
|
data={**data, 'username': 'Superuser', 'is_superuser': True},
|
|
expected_code=201,
|
|
)
|
|
|
|
self.assertEqual(response.data['username'], 'Superuser')
|
|
self.assertEqual(response.data['is_superuser'], True)
|
|
|
|
def test_user_detail(self):
|
|
"""Test the UserDetail API endpoint."""
|
|
user = User.objects.first()
|
|
assert user
|
|
|
|
url = reverse('api-user-detail', kwargs={'pk': user.pk})
|
|
|
|
user.is_staff = False
|
|
user.save()
|
|
|
|
# Any authenticated user can access the user detail endpoint
|
|
self.get(url, expected_code=200)
|
|
|
|
# Let's try to update the user
|
|
data = {'is_active': True, 'is_staff': False}
|
|
|
|
self.patch(url, data=data, expected_code=403)
|
|
|
|
# But, what if we have the "admin" role?
|
|
self.assignRole('admin.change')
|
|
|
|
# Still cannot - we are not staff
|
|
self.patch(url, data=data, expected_code=403)
|
|
|
|
self.user.is_staff = True
|
|
self.user.save()
|
|
|
|
self.patch(url, data=data, expected_code=200)
|
|
|
|
# Try to change the "is_superuser" field - only a superuser can do this
|
|
data['is_superuser'] = True
|
|
response = self.patch(url, data=data, expected_code=403)
|
|
|
|
self.assertIn(
|
|
'You do not have permission to perform this action', str(response.data)
|
|
)
|
|
|
|
self.user.is_staff = True
|
|
self.user.is_superuser = True
|
|
self.user.save()
|
|
|
|
for val in [True, False]:
|
|
data['is_staff'] = True
|
|
data['is_superuser'] = val
|
|
|
|
response = self.patch(url, data=data, expected_code=200)
|
|
self.assertEqual(response.data['is_superuser'], val)
|
|
self.assertEqual(response.data['is_staff'], True)
|
|
|
|
# Try again, but logged out - expect no access to the endpoint
|
|
self.logout()
|
|
self.get(url, expected_code=401)
|
|
|
|
def test_group_api(self):
|
|
"""Tests for the Group API endpoints."""
|
|
response = self.get(reverse('api-group-list'), expected_code=200)
|
|
|
|
self.assertIn('name', response.data[0])
|
|
|
|
self.assertEqual(len(response.data), Group.objects.count())
|
|
|
|
# Check detail URL
|
|
pk = response.data[0]['pk']
|
|
response = self.get(
|
|
reverse('api-group-detail', kwargs={'pk': pk}), expected_code=200
|
|
)
|
|
self.assertIn('name', response.data)
|
|
self.assertNotIn('permissions', response.data)
|
|
|
|
# Check more detailed URL
|
|
response = self.get(
|
|
reverse('api-group-detail', kwargs={'pk': pk}),
|
|
data={'permission_detail': True},
|
|
expected_code=200,
|
|
)
|
|
self.assertIn('name', response.data)
|
|
self.assertIn('roles', response.data)
|
|
self.assertIn('permissions', response.data)
|
|
|
|
self.assertGreater(len(response.data['roles']), 0)
|
|
|
|
def test_login_redirect(self):
|
|
"""Test login redirect endpoint."""
|
|
response = self.get(reverse('api-login-redirect'), expected_code=302)
|
|
self.assertEqual(response.url, '/web/logged-in/')
|
|
|
|
def test_user_roles(self):
|
|
"""Test the user 'roles' API endpoint."""
|
|
url = reverse('api-user-roles')
|
|
|
|
response = self.get(url, expected_code=200)
|
|
data = response.data
|
|
|
|
# User has no 'permissions' yet
|
|
self.assertEqual(len(data['permissions']), 0)
|
|
self.assertEqual(len(data['roles']), len(RULESET_NAMES))
|
|
|
|
# assign the 'purchase_order.add' role to the test group
|
|
self.assignRole('purchase_order.add')
|
|
|
|
response = self.get(url, expected_code=200)
|
|
data = response.data
|
|
|
|
# Expected number of permissions
|
|
perms = get_ruleset_models()['purchase_order']
|
|
self.assertEqual(len(data['permissions']), len(perms))
|
|
|
|
for P in data['permissions'].values():
|
|
self.assertIn('add', P)
|
|
self.assertIn('change', P)
|
|
self.assertIn('view', P)
|
|
|
|
self.assertNotIn('delete', P)
|
|
|
|
# assign a different role - check stacking
|
|
self.assignRole('build.view')
|
|
|
|
response = self.get(url, expected_code=200)
|
|
data = response.data
|
|
build_perms = get_ruleset_models()['build']
|
|
|
|
self.assertEqual(len(data['permissions']), len(perms) + len(build_perms))
|
|
|
|
def test_me_endpoint(self):
|
|
"""Test against the users /me/ endpoint."""
|
|
url = reverse('api-user-me')
|
|
|
|
# Test endpoint options
|
|
response = self.options(url, expected_code=200)
|
|
|
|
# Check that particular fields are present, and have the correct attributes
|
|
fields = response.data['actions']['PUT']
|
|
|
|
for name in [
|
|
'pk',
|
|
'username',
|
|
'email',
|
|
'groups',
|
|
'is_active',
|
|
'is_staff',
|
|
'is_superuser',
|
|
]:
|
|
self.assertIn(name, fields)
|
|
|
|
for name in ['is_active', 'is_staff', 'is_superuser']:
|
|
self.assertTrue(fields[name]['read_only'])
|
|
|
|
# Perform a GET request against the endpoint
|
|
response = self.get(url, expected_code=200)
|
|
|
|
for field in [
|
|
'pk',
|
|
'username',
|
|
'email',
|
|
'is_active',
|
|
'is_staff',
|
|
'is_superuser',
|
|
]:
|
|
self.assertIn(field, response.data)
|
|
|
|
# Change their own username
|
|
for name in ['Henry', 'Sally']:
|
|
response = self.patch(url, data={'username': name}, expected_code=200)
|
|
self.assertEqual(response.data['username'], name)
|
|
|
|
# Defined starting point for the user
|
|
for v in [True, False]:
|
|
self.user.is_staff = v
|
|
self.user.is_superuser = v
|
|
self.user.save()
|
|
|
|
for key in ['is_staff', 'is_superuser']:
|
|
for val in [True, False]:
|
|
response = self.patch(url, data={key: val}, expected_code=200)
|
|
|
|
# Check that the field was *NOT CHANGED*
|
|
self.assertEqual(response.data[key], v)
|
|
|
|
# Ensure we cannot change the "is_active" field either
|
|
response = self.patch(url, data={'is_active': False}, expected_code=200)
|
|
self.assertEqual(response.data['is_active'], True)
|
|
|
|
self.user.is_active = False
|
|
self.user.save()
|
|
|
|
# User cannot fetch their own details if they are not active
|
|
response = self.get(url, expected_code=401)
|
|
|
|
|
|
class SuperuserAPITests(InvenTreeAPITestCase):
|
|
"""Tests for user API endpoints that require superuser rights."""
|
|
|
|
fixtures = ['users']
|
|
superuser = True
|
|
|
|
def test_user_password_set(self):
|
|
"""Test the set-password/ endpoint."""
|
|
user = User.objects.get(pk=2)
|
|
url = reverse('api-user-set-password', kwargs={'pk': user.pk})
|
|
|
|
# to simple password
|
|
resp = self.put(url, {'password': 1}, expected_code=400)
|
|
self.assertContains(resp, 'This password is too short', status_code=400)
|
|
|
|
# now with overwrite
|
|
resp = self.put(
|
|
url, {'password': 1, 'override_warning': True}, expected_code=200
|
|
)
|
|
self.assertEqual(resp.data, {})
|
|
|
|
# complex enough pwd
|
|
resp = self.put(url, {'password': 'inventree'}, expected_code=200)
|
|
self.assertEqual(resp.data, {})
|
|
|
|
|
|
class UserTokenTests(InvenTreeAPITestCase):
|
|
"""Tests for user token functionality."""
|
|
|
|
fixtures = ['users']
|
|
|
|
def test_token_generation(self):
|
|
"""Test user token generation."""
|
|
url = reverse('api-token')
|
|
|
|
self.assertEqual(ApiToken.objects.count(), 0)
|
|
|
|
# Generate multiple tokens with different names
|
|
for name in ['cat', 'dog', 'biscuit']:
|
|
data = self.get(url, data={'name': name}, expected_code=200).data
|
|
|
|
self.assertTrue(data['token'].startswith('inv-'))
|
|
self.assertEqual(data['name'], name)
|
|
|
|
# Check that the tokens were created
|
|
self.assertEqual(ApiToken.objects.count(), 3)
|
|
|
|
# If we re-generate a token, the value changes
|
|
token = ApiToken.objects.filter(name='cat').first()
|
|
assert token
|
|
|
|
# Request the token with the same name
|
|
data = self.get(url, data={'name': 'cat'}, expected_code=200).data
|
|
|
|
self.assertEqual(data['token'], token.key)
|
|
|
|
self.assertEqual(ApiToken.objects.count(), 3)
|
|
|
|
# Revoke the token, and then request again
|
|
token.revoked = True
|
|
token.save()
|
|
|
|
data = self.get(url, data={'name': 'cat'}, expected_code=200).data
|
|
|
|
self.assertNotEqual(data['token'], token.key)
|
|
|
|
# A new token has been generated
|
|
self.assertEqual(ApiToken.objects.count(), 4)
|
|
|
|
# Test with a really long name
|
|
data = self.get(url, data={'name': 'cat' * 100}, expected_code=200).data
|
|
|
|
# Name should be truncated
|
|
self.assertEqual(len(data['name']), 100)
|
|
|
|
token.refresh_from_db()
|
|
|
|
# Check that the metadata has been updated
|
|
keys = [
|
|
'user_agent',
|
|
'remote_addr',
|
|
'remote_host',
|
|
'remote_user',
|
|
'server_name',
|
|
'server_port',
|
|
]
|
|
|
|
for k in keys:
|
|
self.assertIn(k, token.metadata)
|
|
|
|
def test_token_auth(self):
|
|
"""Test user token authentication."""
|
|
# Create a new token
|
|
token_key = self.get(
|
|
url=reverse('api-token'), data={'name': 'test'}, expected_code=200
|
|
).data['token']
|
|
|
|
# Check that we can use the token to authenticate
|
|
self.client.logout()
|
|
self.client.credentials(HTTP_AUTHORIZATION='Token ' + token_key)
|
|
|
|
me = reverse('api-user-me')
|
|
|
|
response = self.client.get(me, expected_code=200)
|
|
|
|
# Grab the token, and update
|
|
token = ApiToken.objects.first()
|
|
assert token
|
|
self.assertEqual(token.key, token_key)
|
|
self.assertIsNotNone(token.last_seen)
|
|
|
|
# Revoke the token
|
|
token.revoked = True
|
|
token.save()
|
|
|
|
self.assertFalse(token.active)
|
|
|
|
response = self.client.get(me, expected_code=401)
|
|
self.assertIn('Token has been revoked', str(response.data))
|
|
|
|
# Expire the token
|
|
token.revoked = False
|
|
token.expiry = datetime.datetime.now().date() - datetime.timedelta(days=10)
|
|
token.save()
|
|
|
|
self.assertTrue(token.expired)
|
|
self.assertFalse(token.active)
|
|
|
|
response = self.client.get(me, expected_code=401)
|
|
self.assertIn('Token has expired', str(response.data))
|
|
|
|
# Re-enable the token
|
|
token.revoked = False
|
|
token.expiry = datetime.datetime.now().date() + datetime.timedelta(days=10)
|
|
token.save()
|
|
|
|
self.client.get(me, expected_code=200)
|
|
|
|
def test_token_api(self):
|
|
"""Test the token API."""
|
|
url = reverse('api-token-list')
|
|
response = self.get(url, expected_code=200)
|
|
self.assertEqual(response.data, [])
|
|
|
|
# Get token
|
|
response = self.get(reverse('api-token'), expected_code=200)
|
|
self.assertIn('token', response.data)
|
|
|
|
# Now there should be one token
|
|
response = self.get(url, expected_code=200)
|
|
self.assertEqual(len(response.data), 1)
|
|
self.assertEqual(response.data[0]['active'], True)
|
|
self.assertEqual(response.data[0]['revoked'], False)
|
|
self.assertEqual(response.data[0]['in_use'], False)
|
|
expected_day = str(
|
|
datetime.datetime.now().date() + datetime.timedelta(days=365)
|
|
)
|
|
self.assertEqual(response.data[0]['expiry'], expected_day)
|
|
|
|
# Destroy token
|
|
self.delete(
|
|
reverse('api-token-detail', kwargs={'pk': response.data[0]['id']}),
|
|
expected_code=204,
|
|
)
|
|
|
|
# Get token without auth (should fail)
|
|
self.client.logout()
|
|
self.get(reverse('api-token'), expected_code=401)
|
|
|
|
def test_token_security(self):
|
|
"""Test that token generation is only available to users with the correct permissions."""
|
|
url = reverse('api-token-list')
|
|
|
|
# Try to generate a token for a different user (should fail)
|
|
response = self.post(url, data={'name': 'test', 'user': 1}, expected_code=400)
|
|
self.assertIn(
|
|
'Only a superuser can create a token for another user', str(response.data)
|
|
)
|
|
|
|
# there should be no tokens created
|
|
self.assertEqual(ApiToken.objects.count(), 0)
|
|
|
|
# now with superuser permissions
|
|
self.user.is_superuser = True
|
|
self.user.save()
|
|
|
|
response = self.post(url, data={'name': 'test', 'user': 1}, expected_code=201)
|
|
self.assertIn('token', response.data)
|
|
|
|
self.assertEqual(ApiToken.objects.count(), 1)
|
|
|
|
|
|
class GroupDetailTests(InvenTreeAPITestCase):
|
|
"""Tests for the GroupDetail API endpoint."""
|
|
|
|
fixtures = ['users']
|
|
|
|
def test_group_list(self):
|
|
"""Test the GroupDetail API endpoint."""
|
|
url = reverse('api-group-detail', kwargs={'pk': 1})
|
|
|
|
response = self.get(url, {'user_detail': 'true'}, expected_code=200)
|
|
self.assertIn('users', response.data)
|
|
|
|
response = self.get(url, {'role_detail': 'true'}, expected_code=200)
|
|
self.assertIn('roles', response.data)
|
|
|
|
response = self.get(url, {'permission_detail': 'true'}, expected_code=200)
|
|
self.assertIn('permissions', response.data)
|
|
|
|
response = self.get(url, {'permission_detail': 'false'}, expected_code=200)
|
|
self.assertNotIn('permissions', response.data)
|