From 232535d166d4b7468566f1c4cbf8856d00d8a632 Mon Sep 17 00:00:00 2001 From: Oliver Date: Wed, 11 Aug 2021 08:14:40 +1000 Subject: [PATCH] Reduce error reporting for model requests --- lib/inventree/model.dart | 72 ++++++++++++++++++++++------------------ 1 file changed, 39 insertions(+), 33 deletions(-) diff --git a/lib/inventree/model.dart b/lib/inventree/model.dart index 11476b7a..2d18db59 100644 --- a/lib/inventree/model.dart +++ b/lib/inventree/model.dart @@ -199,17 +199,19 @@ class InvenTreeModel { if (!response.isValid() || response.data == null || !(response.data is Map)) { // Report error - await sentryReportMessage( - "InvenTreeModel.reload() returned invalid response", - context: { - "url": url, - "statusCode": response.statusCode.toString(), - "data": response.data?.toString() ?? "null", - "valid": response.isValid().toString(), - "error": response.error, - "errorDetail": response.errorDetail, - } - ); + if (response.statusCode > 0) { + await sentryReportMessage( + "InvenTreeModel.reload() returned invalid response", + context: { + "url": url, + "statusCode": response.statusCode.toString(), + "data": response.data?.toString() ?? "null", + "valid": response.isValid().toString(), + "error": response.error, + "errorDetail": response.errorDetail, + } + ); + } showServerError( L10().serverError, @@ -270,17 +272,19 @@ class InvenTreeModel { if (!response.isValid() || response.data == null || !(response.data is Map)) { - await sentryReportMessage( - "InvenTreeModel.get() returned invalid response", - context: { - "url": url, - "statusCode": response.statusCode.toString(), - "data": response.data?.toString() ?? "null", - "valid": response.isValid().toString(), - "error": response.error, - "errorDetail": response.errorDetail, - } - ); + if (response.statusCode > 0) { + await sentryReportMessage( + "InvenTreeModel.get() returned invalid response", + context: { + "url": url, + "statusCode": response.statusCode.toString(), + "data": response.data?.toString() ?? "null", + "valid": response.isValid().toString(), + "error": response.error, + "errorDetail": response.errorDetail, + } + ); + } showServerError( L10().serverError, @@ -311,17 +315,19 @@ class InvenTreeModel { // Invalid response returned from server if (!response.isValid() || response.data == null || !(response.data is Map)) { - await sentryReportMessage( - "InvenTreeModel.create() returned invalid response", - context: { - "url": url, - "statusCode": response.statusCode.toString(), - "data": response.data?.toString() ?? "null", - "valid": response.isValid().toString(), - "error": response.error, - "errorDetail": response.errorDetail, - } - ); + if (response.statusCode > 0) { + await sentryReportMessage( + "InvenTreeModel.create() returned invalid response", + context: { + "url": url, + "statusCode": response.statusCode.toString(), + "data": response.data?.toString() ?? "null", + "valid": response.isValid().toString(), + "error": response.error, + "errorDetail": response.errorDetail, + } + ); + } showServerError( L10().serverError,