Default filters (#749)

* Bug fix for filters

- Fix key shadowing

* Adjust default filters for stock list

* Adjust default filter values

* Add "active" filter for stock items

* Code formatting

lib/inventree/model.dart

@@ -730,8 +730,6 @@ class InvenTreeModel {
 
     var response = await api.get(URL, params: params);
 
-    print("paginated: ${URL}: ${params}");
-
     if (!response.isValid()) {
       return null;
     }

lib/widget/order/purchase_order_list.dart

@@ -133,6 +133,7 @@ class _PaginatedPurchaseOrderListState
       "label": L10().outstanding,
       "help_text": L10().outstandingOrderDetail,
       "tristate": true,
+      "default": true,
     },
     "overdue": {
       "label": L10().overdue,

lib/widget/order/sales_order_list.dart

@@ -115,6 +115,7 @@ class _PaginatedSalesOrderListState
       "label": L10().outstanding,
       "help_text": L10().outstandingOrderDetail,
       "tristate": true,
+      "default": true,
     },
     "overdue": {
       "label": L10().overdue,

lib/widget/paginator.dart

@@ -47,25 +47,28 @@ abstract class PaginatedSearchState<T extends PaginatedSearchWidget>
 
   // Return the boolean value of a particular boolean filter
   Future<dynamic> getFilterValue(String key) async {
-    key = "${prefix}filter_${key}";
+    final String settings_key = "${prefix}filter_${key}";
 
     Map<String, dynamic> opts = filterOptions[key] ?? {};
 
     bool tristate = (opts["tristate"] ?? true) as bool;
-    dynamic backup = tristate ? null : opts["default"];
-    final result = await InvenTreeSettingsManager().getValue(key, backup);
+    dynamic backup = tristate ? opts["default"] : opts["default"] ?? false;
+    final result = await InvenTreeSettingsManager().getValue(
+      settings_key,
+      backup,
+    );
 
     return result;
   }
 
   // Set the boolean value of a particular boolean filter
   Future<void> setFilterValue(String key, dynamic value) async {
-    key = "${prefix}filter_${key}";
+    final String settings_key = "${prefix}filter_${key}";
 
     if (value == null) {
-      await InvenTreeSettingsManager().removeValue(key);
+      await InvenTreeSettingsManager().removeValue(settings_key);
     } else {
-      await InvenTreeSettingsManager().setValue(key, value);
+      await InvenTreeSettingsManager().setValue(settings_key, value);
     }
   }
 

lib/widget/part/part_list.dart

@@ -74,6 +74,7 @@ class _PaginatedPartListState extends PaginatedSearchState<PaginatedPartList> {
       "label": L10().filterActive,
       "help_text": L10().filterActiveDetail,
       "tristate": true,
+      "default": true,
     },
     "assembly": {
       "label": L10().filterAssembly,

lib/widget/stock/stock_list.dart

@@ -75,8 +75,13 @@ class _PaginatedStockItemListState
         "help_text": L10().filterInStockDetail,
         "tristate": true,
       },
+      "active": {
+        "default": true,
+        "label": L10().filterActive,
+        "help_text": L10().filterActiveDetail,
+      },
       "cascade": {
-        "default": false,
+        "default": true,
         "label": L10().includeSublocations,
         "help_text": L10().includeSublocationsDetail,
         "tristate": false,