Barcode refactor (#381)

* Simplify barcode scanning interface

* Use consistent colors

* Fix notches

* Remove old comment

lib/api_form.dart

@@ -349,11 +349,7 @@ class APIFormField {
               );
             });
 
-            Navigator.push(
+            scanBarcode(context, handler: handler);
-              context,
-              MaterialPageRoute(builder: (context) => barcodeController(handler)
-              )
-            );
           },
         ),
       )

lib/app_colors.dart

@@ -18,4 +18,4 @@ Color get COLOR_ACTION {
 const Color COLOR_WARNING = Color.fromRGBO(250, 150, 50, 1);
 const Color COLOR_DANGER = Color.fromRGBO(200, 50, 75, 1);
 const Color COLOR_SUCCESS = Color.fromRGBO(100, 200, 75, 1);
-const Color COLOR_PROGRESS = Color.fromRGBO(50, 100, 200, 1);
+const Color COLOR_PROGRESS = Color.fromRGBO(50, 100, 200, 1);

lib/barcode/barcode.dart

@@ -30,11 +30,25 @@ import "package:inventree/widget/supplier_part_detail.dart";
 
 
 /*
- * Return a new BarcodeController instance
+ * Launch a barcode scanner with a particular context and handler.
+ * 
+ * - Can be called with a custom BarcodeHandler instance, or use the default handler
+ * - Returns a Future which resolves when the scanner is dismissed
+ * - The provided BarcodeHandler instance is used to handle the scanned barcode
  */
-InvenTreeBarcodeController barcodeController(BarcodeHandler handler) {
+Future<Object?> scanBarcode(BuildContext context, {BarcodeHandler? handler}) async {
-  // TODO: Make this configurable
+
-  return CameraBarcodeController(handler);
+  // Default to generic scan handler
+  handler ??= BarcodeScanHandler();
+  
+  InvenTreeBarcodeController controller = CameraBarcodeController(handler);
+
+  return Navigator.of(context).push(
+    PageRouteBuilder(
+      pageBuilder: (context, _, __) => controller,
+      opaque: false,
+    )
+  );
 }
 
 
@@ -525,13 +539,6 @@ class UniqueBarcodeHandler extends BarcodeHandler {
 }
 
 
-Future<void> scanQrCode(BuildContext context) async {
-  Navigator.push(context, MaterialPageRoute(builder: (context) => barcodeController(BarcodeScanHandler())));
-
-  return;
-}
-
-
 SpeedDialChild customBarcodeAction(BuildContext context, RefreshableState state, String barcode, String model, int pk) {
 
   if (barcode.isEmpty) {
@@ -552,13 +559,7 @@ SpeedDialChild customBarcodeAction(BuildContext context, RefreshableState state,
             state.refresh(context);
           });
         });
-
+        scanBarcode(context, handler: handler);
-        Navigator.push(
-            context,
-            MaterialPageRoute(
-                builder: (context) => barcodeController(handler)
-            )
-        );
       }
     );
   } else {

lib/inventree/status_codes.dart

@@ -8,6 +8,7 @@
 import "package:flutter/material.dart";
 
 import "package:inventree/api.dart";
+import "package:inventree/app_colors.dart";
 import "package:inventree/helpers.dart";
 
 
@@ -112,17 +113,17 @@ class InvenTreeStatusCode {
 
     switch (color_name.toLowerCase()) {
       case "success":
-        return Colors.green;
+        return COLOR_SUCCESS;
       case "primary":
-        return Colors.blue;
+        return COLOR_PROGRESS;
       case "secondary":
         return Colors.grey;
       case "dark":
         return Colors.black;
       case "danger":
-        return Colors.red;
+        return COLOR_DANGER;
       case "warning":
-        return Colors.orange;
+        return COLOR_WARNING;
       case "info":
         return Colors.lightBlue;
       default:

lib/widget/home.dart

@@ -181,21 +181,18 @@ class _InvenTreeHomePageState extends State<InvenTreeHomePage> with BaseWidgetPr
         ),
       ),
       onTap: () {
-
         if (!allowed) {
           showSnackIcon(
             L10().permissionRequired,
             icon: FontAwesomeIcons.circleExclamation,
             success: false,
           );
-
           return;
         }
 
         if (callback != null) {
           callback();
         }
-
       },
     );
   }

lib/widget/location_display.dart

@@ -91,11 +91,9 @@ class _LocationDisplayState extends RefreshableState<LocationDisplayWidget> {
                 child: FaIcon(FontAwesomeIcons.qrcode),
                 label: L10().barcodeScanItem,
                 onTap: () {
-                  Navigator.push(
+                  scanBarcode(
-                      context,
+                    context,
-                      MaterialPageRoute(builder: (context) =>
+                    handler: StockLocationScanInItemsHandler(location!),
-                          barcodeController(
-                              StockLocationScanInItemsHandler(location!)))
                   ).then((value) {
                     refresh(context);
                   });
@@ -111,11 +109,9 @@ class _LocationDisplayState extends RefreshableState<LocationDisplayWidget> {
                 child: FaIcon(FontAwesomeIcons.qrcode),
                 label: L10().transferStockLocation,
                 onTap: () {
-                  Navigator.push(
+                  scanBarcode(
-                      context,
+                    context,
-                      MaterialPageRoute(builder: (context) =>
+                    handler: ScanParentLocationHandler(location!),
-                        barcodeController(ScanParentLocationHandler(location!))
-                      )
                   ).then((value) {
                     refresh(context);
                   });

lib/widget/refreshable_state.dart

@@ -102,15 +102,22 @@ mixin BaseWidgetProperties {
         iconSize: iconSize,
         onPressed: () {
           if (InvenTreeAPI().checkConnection()) {
-            scanQrCode(context);
+            scanBarcode(context);
           }
         },
       )
     ];
 
     return BottomAppBar(
-        shape: CircularNotchedRectangle(),
+        shape: AutomaticNotchedShape(
-        notchMargin: 20,
+          RoundedRectangleBorder(
+            borderRadius: BorderRadius.all(Radius.circular(20)),
+          ),
+          RoundedRectangleBorder(
+            borderRadius: BorderRadius.all(Radius.circular(40)),
+          ),
+        ),
+        notchMargin: 10,
         child: IconTheme(
             data: IconThemeData(color: Theme.of(context).colorScheme.onPrimary),
             child: Row(

lib/widget/stock_detail.dart

@@ -165,12 +165,9 @@ class _StockItemDisplayState extends RefreshableState<StockDetailWidget> {
               child: Icon(Icons.qr_code_scanner),
               label: L10().scanIntoLocation,
               onTap: () {
-                Navigator.push(
+                scanBarcode(
-                    context,
+                  context,
-                    MaterialPageRoute(builder: (context) =>
+                  handler: StockItemScanIntoLocationHandler(widget.item)
-                      barcodeController(
-                        StockItemScanIntoLocationHandler(widget.item))
-                      )
                 ).then((ctx) {
                   refresh(context);
                 });