* Fix admin search for StockItemTracking and StockItemTestResult
Add search_fields to StockTrackingAdmin and StockItemTestResultAdmin
- item__part__name: search tracking by part name
- item__serial: search tracking by serial number
- notes: search tracking notes
- stock_item__part__name: search test results by part name
- stock_item__serial: search test results by serial number
- template__test_name: search test results by test template name
- value: search test results by output value
- notes: search test result notes
Also adds a unit test to verify search_fields configuration.
* Fix admin search for PartPricing, PartStocktake, PartRelated, and PartTestTemplate
Add search_fields to PartPricingAdmin, PartStocktakeAdmin, PartRelatedAdmin,
and PartTestTemplateAdmin.
- part__name, part__IPN, part__description: search PartPricing
- part__name, part__IPN: search PartStocktake
- part_1__name, part_2__name: search PartRelated
- part__name, test_name, description: search PartTestTemplate
Also adds unit test assertions to verify search_fields configuration.
* Fix admin search for SalesOrderAllocation and ReturnOrderLineItem
Add search_fields to SalesOrderAllocationAdmin and ReturnOrderLineItemAdmin.
SalesOrderAllocationAdmin:
- line__order__reference: search by Sales Order reference
- line__part__name: search by ordered Part name
- item__part__name: search by allocated Stock Item part name
- item__part__IPN: search by allocated Stock Item IPN
- item__serial: search by Stock Item serial number
ReturnOrderLineItemAdmin:
- order__reference: search by Return Order reference
- order__customer__name: search by Customer name
- item__part__name: search by returned Item part name
- item__serial: search by returned Item serial number
- reference: search by line item reference
Also adds list_display improvements and unit tests to verify
search_fields configuration.
* Fix incorrect identity comparison for status validation
Use '!=' (value comparison) instead of 'is not' (identity comparison)
when comparing custom_status.logical_key with self.instance.status.
Python only caches small integers (-5 to 256). For status codes > 256,
'is not' can return True even when values are equal, causing valid
custom status keys to be incorrectly rejected.
Per PEP 8: always use '==' or '!=' for value comparisons.
* Fix wrong super() method call in DataImportColumnMapAdmin
The formfield_for_dbfield method was incorrectly calling
super().formfield_for_choice_field() instead of super().formfield_for_dbfield().
These are different Django admin methods with different expectations.
formfield_for_choice_field expects choice-type fields, but the 'column'
field is a plain CharField. This could cause incorrect form rendering
or errors when viewing DataImportSession detail in Django Admin.
Fix: call the correct parent method formfield_for_dbfield().
* Fix broken delete() method signature on EmailMessage model
The delete() method used '*kwargs' which collects positional arguments
into a tuple named 'kwargs'. This breaks Django's Model.delete()
contract which expects keyword arguments (using=None, keep_parents=False).
When super().delete(*kwargs) was called, keyword arguments passed by
Django internals would be unpacked incorrectly as positional args.
Fix: use standard '*args, **kwargs' signature and pass both to super().
* Fix bare except clause in order status validation
Replace bare 'except:' with 'except Exception:' in
validate_status_custom_key method.
Bare except catches all BaseException subclasses including SystemExit,
KeyboardInterrupt, and MemoryError which should never be silenced.
The get_logical_value() function performs a database .get() call that
can raise ObjectDoesNotExist or MultipleObjectsReturned, both of which
are subclasses of Exception.
This follows PEP 8 (E722: do not use bare except).
* Fix bare except clauses in machine registry and barcode mixins
Replace bare 'except:' with 'except Exception:' in two locations:
- machine/registry.py: hash computation catches AttributeError or
DoesNotExist when a machine config no longer exists
- plugin/base/barcodes/mixins.py: has_barcode_generation property
catches any error from calling generate(None) on a plugin
Bare except catches all BaseException subclasses including SystemExit
and KeyboardInterrupt which should never be silenced.
This follows PEP 8 (E722: do not use bare except).
* Fix readonly_fields typos and add search_fields in admin classes
* Remove redundant admin field test assertions per review feedback
* Fix file formatting and end-of-file newlines per prek style check
---------
Co-authored-by: Oliver <oliver.henry.walters@gmail.com>
Expand search_fields on PurchaseOrderLineItemAdmin to allow
searching by part name, part description, supplier SKU,
order reference, and supplier name.
Previously, only the optional 'reference' field was searchable,
making it impossible to find line items by part or order details.
- part__part__name: search by underlying Part name
- part__part__description: search by Part description
- part__SKU: search by Supplier SKU
- order__reference: search by Purchase Order reference
- order__supplier__name: search by Supplier name
Also adds a unit test to verify the search_fields are correctly
configured.
Bhumin PaladiyaandOliver